Skip to content

Per-workflow releases ignore changes to the composite actions a workflow wraps #155

Open

Description

@swibrow

What

release.yaml cuts a per-workflow release (<name>-vX tags) for each reusable workflow, filtered by service_path, which is the single workflow file (.github/workflows/<name>.yaml). gh-release.yaml turns that into one --include-path for git-cliff.

A reusable workflow that wraps a composite action under actions/<name>/ (for example datadog-cr-validate in #154) checks the action out at its own commit. A change that only touches the action, such as a fix in actions/datadog-cr-validate/validate.py, therefore produces no new datadog-cr-validate-vX tag, so callers pinned to that tag never get it. Only the umbrella vX tags pick it up.

Where

  • .github/workflows/release.yaml: the prepare-matrix job, which builds {name, path} from .github/workflows/*.yaml
  • .github/workflows/gh-release.yaml: the "Compute commit path filter" step, which accepts a single service_path

Suggested fix

Let service_path take more than one path, and have prepare-matrix add actions/<name>/ when a workflow has a matching action directory. Optionally, also give actions without a wrapper workflow their own <name>-vX tags.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions