Skip to content

/status does not say whether ingestion is actually working #333

Open

Description

@Miracle656

Background

/status is defined at src/api/rest.ts:72 and is the endpoint an uptime
monitor will poll. It answers from the process's own point of view. It does not
report whether any ingester is running, when each venue last produced a price,
or whether an ingester has been crash-looping — which means a service with every
ingester dead still returns a healthy /status and a green uptime check.

This is the issue that makes L163 and L165 useful: both produce information that
currently has nowhere to go.

What to build

Extend /status with per-venue, per-network ingestion health:

  • Last successful write time per (venue, network), and the age of it.
  • Whether that age exceeds an expected interval for that venue.
  • Restart count and last crash message, if L165 has landed; design for it being absent.
  • An overall verdict that an uptime monitor can alert on.

Keep the existing fields — callers depend on them. The route is public: true
and allow-listed from rate limiting in src/app.ts, so it must stay cheap: no
unbounded queries, and do not add a Horizon round-trip to it.

Acceptance criteria

  • /status reports last-write age per venue and network
  • A stale venue is visibly distinct from a healthy one
  • Existing response fields are unchanged
  • The handler issues a bounded, small number of queries regardless of how many pairs exist
  • A test asserts the stale case is reported as unhealthy

Drips Wave · Complexity: Intermediate · 150 points


Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture.
A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.


Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Activity

  1. Oluoma123 commented on Oct 16, 2026

    @Oluoma123

    @Oluoma123 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Good day I am a full stack developer with Over 6 years of experience and I have good practical knowledge on this kindle assign this to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Oluoma123 to this issue.

  2. drips-wave commented on Oct 16, 2026

    @drips-wave

    Congratulations, @Oluoma123! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Oluoma123: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  3. Miracle656 commented on Oct 16, 2026

    @Miracle656
    CollaboratorAuthor

    @Oluoma123 @Azintar — coordination note, not a problem.

    This issue and #273 /status has no documented shape both touch /status and are adjacent but not duplicates:

    Whoever lands second will need to describe the other's fields. Easiest order is #273 first, then this one extends the documented schema rather than racing it. Talk to each other rather than through me if that is easier, and say so here if you would rather swap the order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions