Drop Database in the playground's Storage Usage dialog is undone by the next edit and asks for no confirmation #1747

Activity

1. joshunrau

   added

   BugType: existing behavior is wrongType: existing behavior is wrong

   Priority: MediumReal value; schedule normallyReal value; schedule normally

   Difficulty: LowIsolated change, about 2 hours or lessIsolated change, about 2 hours or less

   Area: Playgroundapps/playground (in-browser instrument editor)apps/playground (in-browser instrument editor)

   on Oct 7, 2026
2. joshunrau commented on Oct 26, 2026

   

   joshunrau

   on Oct 26, 2026

   CollaboratorAuthor

   More actions

   Still reproduces on main (d86740e). Nothing on main has touched StorageUsageDialog.tsx or apps/playground/src/store/ since this was filed, and no open PR fixes it.

   After the fix, Drop Database is Restore Defaults plus logout

   Restore Defaults already resets memory (apps/playground/src/components/Header/ActionsDropdown/RestoreDefaultsDialog.tsx:39-44), and persist then writes the defaults over app. Once Drop Database resets memory too, the only thing it adds is forgetting the API token. That still justifies the button: apps/playground/src/store/slices/auth.slice.ts has only login and revalidateToken, so nothing else removes a stored token before it expires. Keep it, and have the confirmation list what goes: saved instruments, settings (including the API URL) and the login.

   Corrections to the suggested fix

   • Reset in one set, so there is one write and no half-reset state. Add dropDatabase next to resetInstruments in instrument.slice.ts, with its type in store/types.ts: instruments = defaultInstruments, fix: resolve 26 low-difficulty issues, one commit each #1825's loadDefaultInstrument(state), default settings, auth = null. defaultSettings is module-private (apps/playground/src/store/slices/settings.slice.ts:7-9), so export it.
   • Then drop the clearStorage() call. The reset's own write leaves no Saved instrument and no _accessToken in app, and the next set rewrites the key anyway.
   • The reload alternative is racy. In zustand 5.0.15, clearStorage is typed () => void and does not return the removeItem promise (zustand/esm/middleware.mjs:450-453). There is nothing to await before location.reload(), and any set that lands before unload writes the key back.
   • Replace the 2 s sleep with the RestoreDefaultsDialog flow: confirm, run the action, addNotification({ type: 'success' }), close. updateKey and the Deleting... message then go. New strings use t({ en, fr }).
   • Until Every playground store update rewrites about 1.4 MB of built-in examples to IndexedDB #1756 trims partialize (apps/playground/src/store/index.ts:77-82), the reset still writes the whole example catalog, so the Usage figure barely drops. Do not assert on it.

   Tests

   • Unit: the action lives in the slice, so its test goes beside it in fix: resolve 26 low-difficulty issues, one commit each #1825's apps/playground/src/store/slices/__tests__/instrument.slice.test.ts, not in store/__tests__/index.test.ts. That file mocks idb-keyval with plain vi.fn()s, so the test can parse the JSON in vi.mocked(set).mock.lastCall. After login(token), dropDatabase() and one more update, memory and the written app both have no Saved instrument and no token. login runs jwtDecode, so the token needs a base64url JSON payload.
   • E2E: seed Mine with Create New Instrument, as the reproduction does, not with generatePlaygroundURL as fix: resolve 26 low-difficulty issues, one commit each #1825's playground specs do. A share fragment stays in the address bar, so the reload imports the instrument again (Reloading a playground share link after editing its instrument adds a new copy on every load and switches away from the edits #1745) and the assertion fails even with the fix. The post-drop update can be PlaygroundPage.selectInstrument(...) (testing/src/pages/playground/index.page.ts:30-33), so no Monaco typing is needed. Add a case where cancelling the confirmation keeps Mine.
   • The Create New Instrument and actions-menu triggers (CloneButton.tsx:40-42, ActionsDropdown.tsx:31-33) have no accessible name until Playground icon-only buttons have no accessible names, and editor tabs cannot be closed from the keyboard #1763. testing/AGENTS.md asks for data-testid selectors, so add one to each, as PreviewFrame.tsx:65 does, rather than wait for Playground icon-only buttons have no accessible names, and editor tabs cannot be closed from the keyboard #1763.

   Order

   This touches the slices, types.ts and StorageUsageDialog.tsx, not store/index.ts, and with no clearStorage() call it does not depend on how #1756 changes persistence. It needs only #1825, and can land before or after #1737 and #1756. #1825, #1817 and #1660 all edit testing/src/specs/playground.spec.ts.

   _{Triage note written with Claude Code. Code references point at main @ d86740e.}