You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
record-file-deletion e2e spec fails when STORAGE_ENABLED=false, the documented local setup #1905
pnpm test:e2e (and thus pnpm check) cannot pass on a machine that follows .agents/docs/playbooks/run-locally.md. Step 4 of that playbook says to set STORAGE_ENABLED=false in .env unless an S3-compatible service listens on STORAGE_ENDPOINT. With that setting, one spec always fails.
The spec creates a record for the ARBITRARY_SINGLE_FILE instrument. apps/api/src/instrument-records/instrument-records.service.ts:117 refuses that with 503 when storage is not enabled, so the spec stops at its first assertion. The other 404 tests pass.
Why CI does not see it
scripts/generate-env.sh leaves STORAGE_ENABLED=true, and CI passes with no storage service: StorageService.onModuleInit returns early when NODE_ENV is test, and the spec uses only the metadata endpoints.
Possible fixes
Skip the spec when storage is disabled, as an explicit, visible skip.
Or change the playbook: say that STORAGE_ENABLED=false makes this spec fail, and give the setup that makes it pass.
A copied env file does not help, because apps/apidev:test reads the repo .env directly. The spec passed locally with STORAGE_ENABLED=true in .env and a rustfs container on port 9000. I did not test STORAGE_ENABLED=true with no storage service, which is the CI configuration.
Related: #1787 (the tutorials leave storage enabled but not configured). Found while preparing #1904.
Activity