Skip to content

bench: add zccache store to bench/fastled-examples actions/cache path list #151

Closed

Description

@zackees

Problem

The current bench/fastled-examples workflow caches:

path: |
  ~/.fbuild
  ~/.fastled/global_cache
  fastled/.build/pio/\${{ env.BENCH_BOARD }}

It does not cache zccache's per-TU object store. Iter3 warm run (24626590831) confirmed this is load-bearing: 304 MB restored, per-example compile time unchanged vs cold.

Sub-task of #147. Blocked by #149 (need the canonical path from the setup action).

Fix

Once #149 lands and the setup action outputs zccache-store-path:

- name: \"Phase - restore compile cache\"
  uses: actions/cache/restore@v4
  with:
    path: |
      ~/.fbuild
      ~/.fastled/global_cache
      \${{ steps.fbuild-setup.outputs.zccache-store-path }}  # ← add
      fastled/.build/pio/\${{ env.BENCH_BOARD }}
    key: bench-v3-...  # bump version prefix for a clean iter4

Bump CACHE_BUST in bench.config to force iter4 cold, then empty-commit warm rerun. Expected: warm compile drops meaningfully below cold for the first time on this benchmark.

Related

Activity

  1. added
    enhancementNew feature or request
    priority: p2Valuable later follow-up after core path is working
    on Apr 19, 2026
  2. zackees commented on Apr 24, 2026

    @zackees
    MemberAuthor

    Closing this manually: the benchmark workflow change landed in PR #192 (merge commit 8b23243) on 2026-04-22. Auto-close did not fire because that PR merged into the �ench/fastled-examples branch rather than the default branch.

    What shipped:

    • cache restore/save now include steps.fbuild-setup.outputs.zccache-store-path
    • the workflow exports ZCCACHE_CACHE_DIR so zccache uses the cached store path
    • cache key/version and �ench.config were bumped for the iter5 cold/warm rerun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestpriority: p2Valuable later follow-up after core path is working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions