You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
audit: arduino_api — does platform_packages override work? (parent #664) #666
Open crates/fbuild-packages/src/library/arduino_api.rs — confirm the framework URL / commit / sha256 are pinned as const &str and that the only public constructor takes no override.
Open the orchestrator at crates/fbuild-build/src/ — does it consult config.get_env_config(env_name)? for a platform_packages entry naming this framework, and pass the URL+ref through to a with_override constructor? Or does it only ever call the default constructor?
Reply on this issue with:
bug exists — if the orchestrator never reads platform_packages, plus file:line for both the const URL pin and the call site. (may be consumed by multiple orchestrators — search for ArduinoApi::)
fixed / no bug — if an override path exists, plus file:line showing the lookup + override constructor.
Reference
#663 is the original report of this pattern (nxplpc). #664 lists every framework package being audited. Use the same evidence shape: file:line for the const URL pin and for the orchestrator call site.
arduino_api.rs:29 — only entry point pub fn ensure_arduino_api(core_dir: &Path) -> Result<()> takes no override parameter
avr_framework.rs:152, 194 — call sites never read platform_packages before invoking
silabs_core.rs:101, 119 — call sites never read platform_packages before invoking
arduino_mbed_core.rs:174, 192 — call sites never read platform_packages before invoking
NOTES: arduino_api is hardcoded to 1.5.2; no constructor accepts URL/version/sha256 overrides. fbuild silently ignores platform_packages = ArduinoCore-API@<URL>#<sha> in platformio.ini.
Activity
zackees commentedon Jun 20, 2026
VERDICT: bug exists
EVIDENCE:
pub fn ensure_arduino_api(core_dir: &Path) -> Result<()>takes no override parameterplatform_packagesbefore invokingplatform_packagesbefore invokingplatform_packagesbefore invokingNOTES: arduino_api is hardcoded to 1.5.2; no constructor accepts URL/version/sha256 overrides. fbuild silently ignores
platform_packages = ArduinoCore-API@<URL>#<sha>in platformio.ini.docs(arduino-api): record platform_packages override scope decision (#…