You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Open crates/fbuild-packages/src/library/esp8266_framework.rs — confirm the framework URL / commit / sha256 are pinned as const &str and that the only public constructor takes no override.
Open the orchestrator at crates/fbuild-build/src/esp8266/ — does it consult config.get_env_config(env_name)? for a platform_packages entry naming this framework, and pass the URL+ref through to a with_override constructor? Or does it only ever call the default constructor?
Reply on this issue with:
bug exists — if the orchestrator never reads platform_packages, plus file:line for both the const URL pin and the call site.
fixed / no bug — if an override path exists, plus file:line showing the lookup + override constructor.
Reference
#663 is the original report of this pattern (nxplpc). #664 lists every framework package being audited. Use the same evidence shape: file:line for the const URL pin and for the orchestrator call site.
crates/fbuild-packages/src/library/esp8266_framework.rs:22-23 — const ESP8266_FRAMEWORK_VERSION and ESP8266_FRAMEWORK_URL hardcoded
crates/fbuild-packages/src/library/esp8266_framework.rs:31-43 — only constructor Esp8266Framework::new() takes no override; package name "esp8266-arduino" (line 34)
crates/fbuild-build/src/esp8266/orchestrator.rs:60 — call site instantiates framework with default constructor only; no platform_packages env_config reading
No override constructor exists; URL is const &str, not resolved from env_config
NOTES: Matches bug pattern from #663 — framework package pins URL/version in const, only default constructor callable, orchestrator never reads platform_packages override.
Activity
zackees commentedon Jun 20, 2026
VERDICT: bug exists
EVIDENCE:
Esp8266Framework::new()takes no override; package name "esp8266-arduino" (line 34)NOTES: Matches bug pattern from #663 — framework package pins URL/version in const, only default constructor callable, orchestrator never reads platform_packages override.