@ygoldfeld filed as follows pre-open-source:
Flow uses (in code) 0 (for null pointers) (comments just say null as a word and can continue to do so).
- Change it to
nullptr. (The search/replace might be non-trivial.)
- Change the coding guide (it's in source).
Commentary: I ([~ygoldfel]) actually don't really think the value nullptr is all that useful/important. It's a little bit of visual syntactic sugar... but I don't think it makes any real difference in terms of type safety; after all 0 is still usable in almost all the same places (apparently constexpr is an exception... but that is really quite a corner case in practice). nullptr_t - the type - is quite useful indeed, but that is not this ticket. I might be missing something, but actually I doubt I really am. However, for some reason other coders seem to really love nullptr. (My theory is that they miss NULL macro, and this is their revenge on all those jerks who forced them to stop using it at some point.) Anyway, they win: I will join the 21st century on this.
Priority: It's obviously not a huge deal... but the longer it's put off the more annoying it will be. So might as well do it up-front and stop paying the subsequent tax (small though it may be).
Update: I've warmed to it some more; it is nice syntactic sugar at least.
@ygoldfeld filed as follows pre-open-source:
Flow uses (in code)
0(for null pointers) (comments just say null as a word and can continue to do so).nullptr. (The search/replace might be non-trivial.)Commentary: I ([~ygoldfel]) actually don't really think the value
nullptris all that useful/important. It's a little bit of visual syntactic sugar... but I don't think it makes any real difference in terms of type safety; after all0is still usable in almost all the same places (apparently constexpr is an exception... but that is really quite a corner case in practice).nullptr_t- the type - is quite useful indeed, but that is not this ticket. I might be missing something, but actually I doubt I really am. However, for some reason other coders seem to really lovenullptr. (My theory is that they missNULLmacro, and this is their revenge on all those jerks who forced them to stop using it at some point.) Anyway, they win: I will join the 21st century on this.Priority: It's obviously not a huge deal... but the longer it's put off the more annoying it will be. So might as well do it up-front and stop paying the subsequent tax (small though it may be).
Update: I've warmed to it some more; it is nice syntactic sugar at least.