Skip to content

Provide more useful comments - #326

Closed
colleirose wants to merge 1 commit into
Kicksecure:masterfrom
colleirose:comments
Closed

colleirose wants to merge 1 commit into
Kicksecure:masterfrom
colleirose:comments

Conversation

@colleirose

Copy link
Copy Markdown

Changes

This provides more useful and up-to-date comments for some options, and only disables SMT in three different areas to make it simpler to remove if desired (mitigations=auto,nosmt, nosmt=force, l1tf=full,force).

Mandatory Checklist

  • Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint

Optional Checklist

The following items are optional but might be requested in certain cases.

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@adrelanos

Copy link
Copy Markdown
Contributor

This is changing too much at once.

  • Moving around settings around without any changes can be suggested in separate PR if a rationale is provided.
  • Removing nosmt - should be discussed in a separate issue.
  • Comments only changes can go into a separate PR.

@adrelanos adrelanos closed this Oct 13, 2025
@colleirose

Copy link
Copy Markdown
Author

This doesn't remove nosmt, it just doesn't set it as many times. It won't affect the functionality, it just makes it simpler to remove if the user wants to. I also don't think I moved any settings around. But as for the comments only changes, I will make another PR.

@raja-grewal raja-grewal mentioned this pull request Oct 19, 2025
3 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants