[Bug] test_system_parser.py: SystemParser.__init__() got an unexpected keyword argument 'chunker' #1888

Activity

1. Memtensor-AI

   added

   types:bugSomething isn't working | 功能异常Something isn't working | 功能异常

   ai:taskDispatched to AI coding agent | 已派发给 AI 编码任务Dispatched to AI coding agent | 已派发给 AI 编码任务

   contrib:good-first-issueGood for newcomers | 适合新手Good for newcomers | 适合新手

   contrib:help wantedExtra attention is needed | 需要社区帮助Extra attention is needed | 需要社区帮助

   area:coreMOS 编排层 / 框架底座 / 跨模块问题MOS 编排层 / 框架底座 / 跨模块问题

   ai:codingAI agent is coding | AI 正在编码AI agent is coding | AI 正在编码

   on Jun 4, 2026
2. Memtensor-AI

   self-assigned this

   on Jun 4, 2026
3. Memtensor-AI commented on Jun 4, 2026

   

   Memtensor-AI

   on Jun 4, 2026

   CollaboratorAuthor

   More actions

   🤖 AutoDev has picked up this issue and started working on it.

   Task ID: fd17e167182d8111
   Working branch: bugfix/autodev-1888
   Target branch: main
   Workflow: opsp (analysis → coding → testing → PR)

   I will post the PR link here once done. If I need more information, I will ask in the comments.
4. Memtensor-AI

   added a commit that references this issue on Jun 4, 2026

   fix: remove invalid chunker parameter from SystemParser test instanti…

   ...

   This issue will close once commit e53059b is merged into the 'main' branch.

   e53059b
5. Memtensor-AI commented on Jun 4, 2026

   

   Memtensor-AI

   on Jun 4, 2026

   CollaboratorAuthor

   More actions

   ✅ AutoDev task fd17e167182d8111 completed.

   Summary: Fixed all 5 failing tests in test_system_parser.py by removing the invalid chunker parameter from SystemParser instantiation.

   Root Cause

   The SystemParser.__init__() method signature was refactored to accept (embedder: BaseEmbedder, llm: BaseLLM | None = None), removing the chunker parameter. However, the test file at line 20 still used the old signature SystemParser(embedder=self.mock_embedder, chunker=None), causing a TypeError for all 5 test methods.

   Changes Made

   • File: tests/mem_reader/test_system_parser.py
   • Change: Removed chunker=None argument from line 20 in the setUp() method
   • Impact: All 5 tests now instantiate SystemParser correctly with the current signature

   Verification

   • Verified the fix by inspecting the current SystemParser implementation at src/memos/mem_reader/read_multi_modal/system_parser.py:34
   • Confirmed no other test files in the codebase use the old SystemParser signature with chunker parameter
   • The fix is minimal, surgical, and directly addresses the issue reported in [Bug] test_system_parser.py: SystemParser.__init__() got an unexpected keyword argument 'chunker' #1888

   Tests Fixed

   1. test_parse_fast_preserves_tool_schema_memory_type
   2. test_parse_fast_with_empty_content_returns_empty
   3. test_parse_fast_with_internal_review_prompt_returns_empty
   4. test_parse_fast_with_regular_system_prompt_returns_empty
   5. test_parse_fast_with_tool_schema_creates_tool_schema_memory

   This fix unblocks CI for all branches including dev and all AutoDev PRs.

   Base branch: main
   Branch: bugfix/autodev-1888
   Commit: e53059b
   PR: #1889
   Assigned to: @MatthewZhuang, @CarltonXiang, @syzsunshine219
   Reviewers: @MatthewZhuang, @CarltonXiang, @syzsunshine219
6. Memtensor-AI

   added

   ai:testingAI agent is running tests | AI 正在运行测试AI agent is running tests | AI 正在运行测试

   ai-done

   and removed

   ai:codingAI agent is coding | AI 正在编码AI agent is coding | AI 正在编码

   ai:testingAI agent is running tests | AI 正在运行测试AI agent is running tests | AI 正在运行测试

   ai:taskDispatched to AI coding agent | 已派发给 AI 编码任务Dispatched to AI coding agent | 已派发给 AI 编码任务

   on Jun 4, 2026
7. MatthewZhuang

   added a commit that references this issue on Jun 14, 2026

   Fix #1888: [Bug] test_system_parser.py: SystemParser.__init__() got a…

   ...

   This issue will close once commit 576b408 is merged into the 'main' branch.

   576b408
8. sarkarshrayan2-max commented on Jun 14, 2026

   

   sarkarshrayan2-max

   on Jun 14, 2026

   More actions

   can you assign me the work i want to work on this
9. syzsunshine219

   added a commit that references this issue on Jul 2, 2026

   Dev 20260604 v2.0.19 (#2033)

   ...

   This issue will close once commit 4e9bbce is merged into the 'main' branch.

   4e9bbce
10. CarltonXiang

    added a commit that references this issue on Jul 2, 2026

    Fix #1523: [Bug] timed_with_status decorator silently swallows except…

    ...

    This issue will close once commit ca75756 is merged into the 'main' branch.

    ca75756
11. CarltonXiang

    closed this as completedin 4e9bbceon Jul 3, 2026
12. syzsunshine219

    added 2 commits that reference this issue on Jul 23, 2026

    feat: chunk batch reflection scoring (#1957)

    ...

    This issue will close once commit 21a27ed is merged into the 'main' branch.

    21a27ed

    fix: remove 500-row cap that truncated viewer count displays (#1954)

    ...

    This issue will close once commit 63ddb97 is merged into the 'main' branch.

    63ddb97
13. Zhe-SH-CN

    added 3 commits that reference this issue on Jul 23, 2026

    feat: chunk batch reflection scoring (MemTensor#1957)

    ...

    This issue will close once commit d9130a7 is merged into the 'main' branch.

    d9130a7

    feat: chunk batch reflection scoring (MemTensor#1957)

    ...

    This issue will close once commit 87b0738 is merged into the 'main' branch.

    87b0738

    feat: chunk batch reflection scoring (MemTensor#1957)

    ...

    This issue will close once commit f8a887d is merged into the 'main' branch.

    f8a887d
14. CarltonXiang

    added a commit that references this issue on Jul 24, 2026

    release: merge dev-v2.0.25 into main (#2156)

    ...

    This issue will close once commit e820406 is merged into the 'main' branch.

    e820406
15. steven-stack-s

    added 3 commits that reference this issue on Sep 18, 2026

    Dev 20260604 v2.0.19 (MemTensor#2033)

    ...

    This issue will close once commit 8001941 is merged into the 'main' branch.

    8001941

    feat: chunk batch reflection scoring (MemTensor#1957)

    ...

    This issue will close once commit c9a80d5 is merged into the 'main' branch.

    c9a80d5

    release: merge dev-v2.0.25 into main (MemTensor#2156)

    ...

    This issue will close once commit a447579 is merged into the 'main' branch.

    a447579