Repository navigation
MilestonesService.resolveIssue's incremental-release model has no counterpart in the real mergefi-milestones contract #162
Description
MilestonesService.resolveIssue() distributes a milestone's budget by repeatedly calling EscrowService.releasePartial() against one Escrow row that was fund()-ed once for the milestone's full budget and stays LOCKED across many partial releases (one per resolved issue).
The real mergefi-milestones contract (MergeFi/contracts, contracts/milestones/src/lib.rs) models this completely differently: create_milestone() opens a budget pool, allocate(milestone_id, issue_id, amount) reserves a slice of the unallocated remainder for one specific issue_id (admin-only, rejects over-allocation), and release_issue(milestone_id, issue_id, recipients) pays out that specific issue's already-reserved slice. There is no "partially release from a locked escrow" primitive at all — resolveIssue's even-split-of-remainingBudget-across-openIssues logic, and its single ever-LOCKED Escrow row, don't correspond to anything the real contract exposes. Making milestones work against the real contract needs MilestonesService to track per-issue allocations (mirroring allocate/release_issue) rather than one shared escrow drained via repeated partial releases — a data-model change in this service, not just an argument-encoding fix in SorobanClientService.
Activity
Syringe7 commentedon Aug 21, 2026
I would love to work on this issue. please assign to me to work on it ASAP
Syringe7 commentedon Aug 21, 2026
I would love to work on this issue. please assign to me to work on it ASAP
codefather2026 commentedon Aug 26, 2026
@codefather2026 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @codefather2026 to this issue.
rubbathabrahband commentedon Aug 26, 2026
@bade22brazy has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @bade22brazy to this issue.
drips-wave commentedon Aug 26, 2026
Congratulations, @bade22brazy! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.
🧑💻 @bade22brazy: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
escrow: document the real mergefi-milestones allocate/release_issue m…
milestones: reject resolving an issue that is already resolved (#162)
Merge pull request #221 from thefadah/fix/issues-151-160-162-164
drips-wave commentedon Aug 26, 2026
This issue has been completed by @bade22brazy as part of the Stellar Wave Program's 8th Wave 🥳
😎 @bade22brazy: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.