Repository navigation
BountiesService.approve/reject and MilestonesService.allocateBudget are unimplemented no-op stubs that never touch the database #253
Description
BountiesService.approve/reject (src/bounties/bounties.service.ts) and MilestonesService.allocateBudget (src/milestones/milestones.service.ts) are:
approve(id: string) {
return Promise.resolve({ id, status: 'approved' });
}
reject(id: string) {
return Promise.resolve({ id, status: 'rejected' });
}allocateBudget(id: string) {
return Promise.resolve({ id, status: 'budget_allocated' });
}None of the three queries the DB, checks the state machine, or even verifies id refers to a real row — a completely bogus UUID gets a 200 with {id, status: 'approved'}. BountyStatus (src/common/enums/index.ts) has no APPROVED/REJECTED value at all, so POST /bounties/:id/approve and /reject cannot possibly be wired to any real transition — they're dead ends. All three routes are wrapped in @UseGuards(JwtAuthGuard, RolesGuard) + @Roles(MAINTAINER) and (for approve/reject) @Idempotent(...), which makes them look like real, audited, money-adjacent actions to any API consumer or integrator, when in fact calling them accomplishes nothing.
Fix: either wire these to real state transitions (e.g. an APPROVED pre-funding gate, or remove approve/reject/allocateBudget entirely if they're vestigial) or delete the routes/stub methods so the API surface doesn't lie about what it does.
Activity
shobhamerabacha-star commentedon Sep 16, 2026
Hey maintainers,
I would love to take this on. My planned approach:
BountiesService.approve/reject and MilestonesService.allocateBudget are unimplemented no-op stubs that never touch the databasewith secure data access and transaction boundaries.Looking forward to collaborating on this—please assign!
EmperorNexus commentedon Sep 23, 2026
@EmperorNexus has applied to work on this issue as part of the Stellar Wave Program's 9th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @EmperorNexus to this issue.
Audukuma commentedon Sep 23, 2026
@Audukuma has applied to work on this issue as part of the Stellar Wave Program's 9th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Audukuma to this issue.
floraispretty commentedon Sep 23, 2026
@floraispretty has applied to work on this issue as part of the Stellar Wave Program's 9th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @floraispretty to this issue.
drips-wave commentedon Sep 23, 2026
Congratulations, @floraispretty! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.
🧑💻 @floraispretty: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
drips-wave commentedon Sep 23, 2026
This issue has been completed by @floraispretty as part of the Stellar Wave Program's 9th Wave 🥳
😎 @floraispretty: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.
docs(api): mark the stub allocate/approve/reject routes deprecated in…