Skip to content

common/validators/date.validator.ts has no spec file #604

Open

Description

@chonilius

Problem

src/common/validators/date.validator.ts IsFutureDate enforces future deadlines (#108, #171). There is no *.spec.ts beside it, and no other spec imports it.

Suggested fix

Add a unit spec covering: past, now and future dates, an invalid string and a non-string.

Related: #108, #171

Activity

  1. added
    testingTesting/QA infrastructure
    Stellar WaveIssues in the Stellar wave program
    and removed
    Stellar WaveIssues in the Stellar wave program
    on Oct 13, 2026
  2. DeFex-lab commented on Oct 19, 2026

    @DeFex-lab

    @DeFex-lab has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I’d be happy to take ownership of this issue and deliver a quality pull request once completed.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @DeFex-lab to this issue.

  3. drips-wave commented on Oct 19, 2026

    @drips-wave

    Congratulations, @DeFex-lab! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @DeFex-lab: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  4. drips-wave commented on Oct 26, 2026

    @drips-wave

    This issue has been marked as completed by a Drips Wave moderator for @DeFex-lab as part of the Stellar Wave Program's 10th Wave 🥳

    Moderator's reason: [Auto-assessed] The PR provides the requested unit tests for the IsFutureDate validator, there are no maintainer objections or review comments across any channel, and the Vercel deployment failure is a non-actionable authorization check for fork PRs. No maintainer response across any of the four channels.

    😎 @DeFex-lab: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

    ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programgood first issueGood for newcomerstestingTesting/QA infrastructure

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions