Repository navigation
refactor: JSTL taglib URIs to jakarta.tags.* (PR 7 of jakarta migration #861) - #941
Open
ismisepaul wants to merge 14 commits into
Open
ismisepaul wants to merge 14 commits into
ismisepaul wants to merge 14 commits into
Conversation
#861) translation.jsp is the only JSP declaring taglibs; the seven JSTL pages (index, login, register, setup, getStarted, readyToPlay, blockedMessage) include it. JSTL 3.0 still resolves the legacy java.sun.com URIs, so this is modernisation rather than a fix. The jakarta.tags.core/fmt URIs are declared in the bundled jakarta.servlet.jsp.jstl 3.0.1 TLDs. Closes #880 Refs #861 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
Both replacements match the bundled JSTL version and leave existing translation behavior unchanged.
No open issues 🎉
What changed in this PR
Modernizes the shared JSP tag library declarations as part of the Jakarta migration, completing the two-line change described in #880.
Changes:
- Replaces the legacy JSTL core and formatting URIs with
jakarta.tags.coreandjakarta.tags.fmt. - Preserves translation logic and the shared include used by seven JSP pages.
| File | Description |
|---|---|
src/main/webapp/translation.jsp |
Updates both tag library URIs to their canonical JSTL 3.0 names. |
Review effort: Balanced
ismisepaul
added this pull request to stack #943
October 22, 2026 21:01
ismisepaul
removed this pull request from stack #943
October 23, 2026 06:26
ismisepaul
added this pull request to stack #945
October 23, 2026 06:27
ismisepaul
removed this pull request from stack #945
October 23, 2026 06:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 7 of the Jakarta migration stack (#861)
Stacked on PR 6.
src/main/webapp/translation.jspis the only JSP that declares taglibs; the seven JSTL pages (index,login,register,setup,getStarted,readyToPlay,blockedMessage) include it. Its two URIs move tojakarta.tags.core/jakarta.tags.fmt, which the bundledjakarta.servlet.jsp.jstl3.0.1 TLDs declare.JSTL 3.0 still resolves the legacy
java.sun.comURIs, so this is modernisation, not a fix.Rest of the #861 checklist
Swept the tree for anything else on the old namespace: no
javax.*in any JSP,web.xmlor resources. The remainingjavaximports are JDK APIs that keep the name (javax.crypto,javax.xml.parsers,javax.xml.namespace,javax.sql.rowset), andjakarta.mailwas already in place.Verification
Docker smoke test on Tomcat 11:
login.jsp?lang=esrenders Spanish strings viafmt:message, with no unprocessed tags in the output.Closes #880
Refs #861
🤖 Generated with Claude Code