Skip to content

refactor: JSTL taglib URIs to jakarta.tags.* (PR 7 of jakarta migration #861) - #941

Open
ismisepaul wants to merge 14 commits into
feat/jakarta-06-webxml-dockerfrom
feat/jakarta-07-jsp-taglibs
Open

ismisepaul wants to merge 14 commits into
feat/jakarta-06-webxml-dockerfrom
feat/jakarta-07-jsp-taglibs

Conversation

@ismisepaul

Copy link
Copy Markdown
Member

PR 7 of the Jakarta migration stack (#861)

Stacked on PR 6.

src/main/webapp/translation.jsp is the only JSP that declares taglibs; the seven JSTL pages (index, login, register, setup, getStarted, readyToPlay, blockedMessage) include it. Its two URIs move to jakarta.tags.core / jakarta.tags.fmt, which the bundled jakarta.servlet.jsp.jstl 3.0.1 TLDs declare.

JSTL 3.0 still resolves the legacy java.sun.com URIs, so this is modernisation, not a fix.

Rest of the #861 checklist

Swept the tree for anything else on the old namespace: no javax.* in any JSP, web.xml or resources. The remaining javax imports are JDK APIs that keep the name (javax.crypto, javax.xml.parsers, javax.xml.namespace, javax.sql.rowset), and jakarta.mail was already in place.

Verification

Docker smoke test on Tomcat 11: login.jsp?lang=es renders Spanish strings via fmt:message, with no unprocessed tags in the output.

Closes #880
Refs #861

🤖 Generated with Claude Code

ismisepaul and others added 2 commits October 22, 2026 20:48
#861)

translation.jsp is the only JSP declaring taglibs; the seven JSTL pages
(index, login, register, setup, getStarted, readyToPlay, blockedMessage)
include it. JSTL 3.0 still resolves the legacy java.sun.com URIs, so
this is modernisation rather than a fix. The jakarta.tags.core/fmt URIs
are declared in the bundled jakarta.servlet.jsp.jstl 3.0.1 TLDs.

Closes #880
Refs #861

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both replacements match the bundled JSTL version and leave existing translation behavior unchanged.

No open issues 🎉

What changed in this PR

Modernizes the shared JSP tag library declarations as part of the Jakarta migration, completing the two-line change described in #880.

Changes:

  • Replaces the legacy JSTL core and formatting URIs with jakarta.tags.core and jakarta.tags.fmt.
  • Preserves translation logic and the shared include used by seven JSP pages.
File Description
src/​main/​webapp/​translation.jsp Updates both tag library URIs to their canonical JSTL 3.0 names.

Review effort: Balanced

@ismisepaul
ismisepaul added this pull request to stack #943 October 22, 2026 21:01
Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both URI replacements match the configured JSTL 3.0 implementation, and no blocking issues were identified.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The two URI replacements match the configured JSTL dependencies, and the reported Spanish-rendering smoke test supports preserved translation behavior.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both URI replacements match the bundled JSTL 3.0 implementation, and the reported Spanish-page smoke test confirms translation rendering.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both replacements match the configured JSTL implementation, and the reported Spanish-language smoke test confirms translation rendering.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The two URI replacements match the configured JSTL implementation, with no unresolved findings and a reported successful Spanish-rendering smoke test.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 22, 2026 22:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both URI replacements are supported by the configured JSTL implementation, with no consumer changes or unresolved issues.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 22, 2026 22:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The two URI replacements match JSTL 3.0, leave locale handling unchanged, and are supported by the reported Spanish-rendering smoke test.

No open issues 🎉

Review effort: Balanced

@ismisepaul
ismisepaul removed this pull request from stack #943 October 23, 2026 06:26
@ismisepaul
ismisepaul added this pull request to stack #945 October 23, 2026 06:27
@ismisepaul
ismisepaul removed this pull request from stack #945 October 23, 2026 06:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The two URI replacements match the bundled JSTL version, and the reported Spanish-language smoke test confirms translation rendering.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 23, 2026 07:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both replacements match JSTL 3.0, preserve the shared translation behavior, and have no unresolved review findings.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 23, 2026 07:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both URI replacements match the configured JSTL implementation, and the narrowly scoped change has no unresolved findings.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 23, 2026 07:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both URI replacements match the configured JSTL 3.0 implementation, with no changes to translation behavior or unresolved findings.

No open issues 🎉

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants