Skip to content
This repository was archived by the owner on Apr 19, 2018. It is now read-only.
This repository was archived by the owner on Apr 19, 2018. It is now read-only.

Responsiveness #1

Open
Open

Description

@Zaturrby

Feature Draft: Responsiveness

Introduction

Currently the styles are written without specific media queries for mobile screen sizes. It would be awesome if mobile users can use Offcourse, or at least part of it. This specification is on how to do this.

Tech

Currently there are 10 breakpoints defined in the configuration of the stylesheets. While these are mostly used for typographic definitions, the lowest few need specific attention, changing the layout. Most modules are already defined in a flexible manner, but some have a fixed width or are compressing the content beyond recognition. Mobile screen sizes also have different UI/UX concerns in some cases. For instance to keep the collection pages easily browsable it might be desirable to hide some content on the card, and make it available on click/tap.

Docs

These are changes to the styles: Check the modules of the style guide. Also check the Styles section of the docs for general information about the styles. Thirdly check the contribution workflow.

Todo

  • Check one or all modules for responsive issues
  • Try to resolve them without media queries if possible
  • Switch to adding a media queries if the layout needs to be significantly changed
  • Implement UI/UX concerns, like collapsable on hover/active.
  • Test you implementation on all screen sizes and zoom levels.
  • Write up to contextualize your changes and submit a pull request

As this feature could also be split up into multiple pull requests, depending on you knowledgeability with this issue, you could also choose to submit this on a module by module basis and ask for reviews on specific code changes.

Contribution Specifics

Deliver via pull request to the the offcourse-frontend repository.

Knowledge requirement: Basic Clojure and Garden + Advanced (modular) CSS
Time requirement: approx. 1 day.

Activity

  1. self-assigned this
    on Jul 30, 2016
  2. modified the milestone: August Deploy on Jul 30, 2016
  3. yeehaa123 commented on Aug 5, 2016

    @yeehaa123

    Hey RJ,

    This is really good. Let's use this template for all feature requests. I do think this feature may be a bit too difficult for someone new to the project. Especially since mobile readiness probably needs some redesigns from Donald. Maybe we can think of some form of tagging/labelling system.

    Could you maybe try to fit one of the features requests that we have discussed Wednesday (f.i. the slack thing) in the same format?

    Great work!

    JH

  4. Zaturrby commented on Aug 5, 2016

    @Zaturrby
    ContributorAuthor

    Great! Will write out one one of the other features tonight or tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions