You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We provide openeo python client library already on pypi.org, but it could be beneficial to our adoption rate and installation friendliness to also provide it through conda on conda-forge channel.
I'm not sure at the moment what has to happen to make it possible, how much additional maintenance it would require and if it is all worth the trouble. Just putting it out here to collect some feedback, if any.
Hi @sebastian-luna-valero , thanks this is very helpfull, as we don't have experience with this ourselves!
Stefaan is on holiday, so he may not reply for a few weeks.
I had a look at the recipe, looks fine for me. You can add me as a maintainer as well.
Hi Sebastian,
seems much needed that we also have some windows and OSX testing.
I'm afraid these point to some actual issues, and seem to remember that they were not super easy to solve.
Is it ok if my colleague Stefaan has a look at this in august?
Otherwise, we may need to come up with some temporary workaround...
hi @sebastian-luna-valero sorry for the delay.
As noted in conda-forge/staged-recipes#15717 it would be interested to know how you trigger that h5netcdf runtime issue. (We might have to fix that in python client itself, not only the conda recipe)
@sebastian-luna-valero could it be that the dependency listing in the conda recipy needs a bit more fine-tuning or pruning?
Note that it is an explicit goal of the openeo package to be as light as possible dependency-wise
@sebastian-luna-valero
(FYI: I didn't have time to dive into the details yet, I just wanted to quickly mention this here.)
If I understand correctly these additional dependencies are probably secondary side-effects of depending on the conda variants of numpy/pandas/shapely/xarray. Not much we can do then on the level of the openeo recipe.
Do you know approaches or tools to keep these things in sync? Yesterday for example, I added a new test dependency, which eventually should be added to the conda recipy too.
Thanks by the way for pushing this ticket, and apologies it took so long to get all the kinks out.
@sebastian-luna-valero I just released version 0.15.0 of python client. Can you walk me through the steps required to also get that release in conda-forge?
Activity
enolfc commentedon Jul 21, 2021
We do manage most packages with conda in the EGI Notebooks service and having packages in conda would simplify the installation of OpenEO.
sebastian-luna-valero commentedon Jul 22, 2021
Hi,
I am happy to help create a conda package for
openeo-python-client. Here is the first attempt:conda-forge/staged-recipes#15717
@soxofaan could you please have a look and provide feedback? Would you like to be included as a conda package maintaner?
Best regards,
Sebastian
jdries commentedon Jul 22, 2021
Hi @sebastian-luna-valero , thanks this is very helpfull, as we don't have experience with this ourselves!
Stefaan is on holiday, so he may not reply for a few weeks.
I had a look at the recipe, looks fine for me. You can add me as a maintainer as well.
sebastian-luna-valero commentedon Jul 22, 2021
Thanks @jdries
Great, I will add you as a maintainer as well.
I have got
pytestworking on Linux only. Could you have a look at the errors for OSX and Windows here and let me know your thoughts, please?Best regards,
Sebastian
jdries commentedon Jul 22, 2021
Hi Sebastian,
seems much needed that we also have some windows and OSX testing.
I'm afraid these point to some actual issues, and seem to remember that they were not super easy to solve.
Is it ok if my colleague Stefaan has a look at this in august?
Otherwise, we may need to come up with some temporary workaround...
sebastian-luna-valero commentedon Jul 23, 2021
Hi Jeroen,
I am happy to wait until Stefaan can have a look.
It is also possible to just build and release the conda package for Linux, and forget about OSX and Windows for now.
Best regards,
Sebastian
sebastian-luna-valero commentedon Aug 6, 2021
Hi,
FYI: I will be on leave the last two weeks of August, so I will be available to help with the conda package either next week or after 31st of August.
Best regards,
Sebastian
HTTP server thread tests: use address instead of fqdn (#176 related)
soxofaan commentedon Aug 16, 2021
Hi @sebastian-luna-valero thanks for bootstrapping this! I already had a quick look at conda-forge/staged-recipes#15717
I also did a minor tweak that should hopefully fix the failing tests on osx
sebastian-luna-valero commentedon Aug 31, 2021
Many thanks @soxofaan
I am now updating the recipe. Let's continue the discussion over there, please.
sebastian-luna-valero commentedon Sep 9, 2021
Hi @soxofaan
Do you need more time before we continue working on conda-forge/staged-recipes#15717? Or can I add
h5netcdfback to the list of runtime dependencies?Best regards,
Sebastian
soxofaan commentedon Sep 30, 2021
hi @sebastian-luna-valero sorry for the delay.
As noted in conda-forge/staged-recipes#15717 it would be interested to know how you trigger that h5netcdf runtime issue. (We might have to fix that in python client itself, not only the conda recipe)
sebastian-luna-valero commentedon Sep 30, 2021
Hi @soxofaan
No worries. I added my comments to the
conda-forgePR.Fix OIDC tests on windows (Issue #252, #176)
soxofaan commentedon Jan 4, 2023
FYI: under #198 and #351 , windows support was improved and now the test suite should run fully on windows too
sebastian-luna-valero commentedon Jan 9, 2023
Thanks, following up discussion on conda-forge/staged-recipes#15717
Issue #176 XarrayDataCube tests: only test scipy engine against itself
Issue #176 XarrayDataCube tests: skip scipy for int64 tests
soxofaan commentedon Feb 13, 2023
Ok it seems openeo is now available for conda (forge): https://anaconda.org/conda-forge/openeo
I just tried to install it in a fresh conda env (with python 3.9) and it gave this package plan:
This looks quite a bit more than what a standard pip install drags in:
@sebastian-luna-valero could it be that the dependency listing in the conda recipy needs a bit more fine-tuning or pruning?
Note that it is an explicit goal of the openeo package to be as light as possible dependency-wise
sebastian-luna-valero commentedon Feb 14, 2023
Hi @soxofaan
I see. However, what we added to the conda recipe:
https://github.com/conda-forge/openeo-feedstock/blob/main/recipe/meta.yaml#L25
Is equal to what we have in:
https://github.com/Open-EO/openeo-python-client/blob/master/setup.py#L54
So the differences are due to the dependency resolution made by
conda/mambavspip.What would you modify in the conda recipe then?
soxofaan commentedon Feb 14, 2023
@sebastian-luna-valero
(FYI: I didn't have time to dive into the details yet, I just wanted to quickly mention this here.)
If I understand correctly these additional dependencies are probably secondary side-effects of depending on the conda variants of numpy/pandas/shapely/xarray. Not much we can do then on the level of the openeo recipe.
Another related question:
Do you know approaches or tools to keep these things in sync? Yesterday for example, I added a new test dependency, which eventually should be added to the conda recipy too.
Thanks by the way for pushing this ticket, and apologies it took so long to get all the kinks out.
sebastian-luna-valero commentedon Feb 14, 2023
Sorry, I don't know.
No worries, and thanks for your support!
soxofaan commentedon Feb 15, 2023
👍
I think we can close this ticket for now.
Thanks again for all the work
Issue #176 basic documentation of conda install
soxofaan commentedon Mar 3, 2023
@sebastian-luna-valero I just released version 0.15.0 of python client. Can you walk me through the steps required to also get that release in conda-forge?
sebastian-luna-valero commentedon Mar 6, 2023
Hi @soxofaan
conda-forge automatically opens a PR when a new version of the source code is available: conda-forge/openeo-feedstock#1
Since you are listed as a recipe maintainer you are also notified. It's now up to us to review and merge that PR.
Once the PR is merged, the new conda package will be created and released via the conda-forge channel.
Development docs: add instructions about updating conda-forge package (…