Skip to content

Eliminate duplication between DataCube, VectorCube, ... #278

Open

Description

@soxofaan

with addition of MlModel (5d074cb), we have now three classes that duplicate a lot of internals:

  • DataCube
  • VectorCube
  • MlModel

e.g. MlModel is more than 100 LoC, but only 10 is actually MlModel specific, the rest is copied from DataCube. In VectorCube it's even worse

I think these duplicated internals should be moved to a common base

Activity

  1. soxofaan commented on Mar 11, 2022

    @soxofaan
    MemberAuthor
  2. added 13 commits that reference this issue on Mar 16, 2022
  3. soxofaan commented on Jun 1, 2023

    @soxofaan
    MemberAuthor

    Another use case: with LocalConnection there is also some overlap/duplication with Connection to be eliminated

  4. soxofaan commented on Aug 9, 2023

    @soxofaan
    MemberAuthor

    also related to #402

  5. changed the title [-]Eliminate datacube duplication[/-] [+]Eliminate duplication between DataCube, VectorCube, ...[/+] on Aug 9, 2023
  6. added a commit that references this issue on Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions