Skip to content

Confusing daterange and bbox filter methods on ImageCollection classes #67

New issue
New issue
Closed
Closed
Confusing daterange and bbox filter methods on ImageCollection classes#67
Assignees
soxofaan

Description

@soxofaan
soxofaan
opened on Jul 18, 2019

Base class ImageCollection (in openeo.imagecollection)

  • defines date_range_filter(self, start_date,end_date)
    • not implemented (just pass)
    • flagged in docblock as deprecated (use filter_daterange instead)
  • defines filter_daterange(self, extent)
    • implemented basically by calling date_range_filter()

Child classes (ImageCollectionClient in openeo.rest and GeotrellisTimeSeriesImageCollection in GeoPyspark driver):

  • override date_range_filter(self, start_date,end_date) with actual implementation
  • no def of filter_daterange(self, extent)

Same pattern for bbox_filter and filter_bbox

So the deprecated methods are implemented and the new non-deprecated calls forward to deprecated implementations? Shouldn't it be the other way around?

Activity

  1. soxofaan
    self-assigned this
    on Jul 18, 2019
  2. soxofaan
    added 12 commits that reference this issue on Jul 19, 2019

    Issue Open-EO#67: add `filter_temporal` and deprecate the old version…

    c456af0

    fixup! Issue Open-EO#67: add `filter_temporal` and deprecate the old …

    a7259bf

    fixup! fixup! Issue Open-EO#67: add `filter_temporal` and deprecate t…

    03d0698

    fixup! fixup! fixup! Issue Open-EO#67: add `filter_temporal` and depr…

    2783ddc

    Issue Open-EO#67: make `filter_bbox` the main method and deprecated `…

    c804a9a

    fixup! Issue Open-EO#67: make `filter_bbox` the main method and depre…

    fadb94f

    fixup! fixup! Issue Open-EO#67: make `filter_bbox` the main method an…

    6a60a5e

    fixup! Issue Open-EO#67: add `filter_temporal` and deprecate the old …

    41e7033

    Issue Open-EO#67: add `filter_temporal` and deprecate the old version…

    3d58b57

    Issue Open-EO#67: make `filter_bbox` the main method and deprecated `…

    7a9e9d1

    Issue Open-EO#67: make `filter_bbox` the main method and deprecated `…

    a91a386

    Issue Open-EO#67 improve date (object) handling in `filter_temporarl`

    e8d982a
  3. soxofaan
    added 3 commits that reference this issue on Aug 5, 2019

    Issue Open-EO#67: add `filter_temporal` and deprecate the old version…

    57a60d9

    Issue Open-EO#67: make `filter_bbox` the main method and deprecated `…

    6c6abcb

    Issue Open-EO#67 improve date (object) handling in `filter_temporal`

    c5c035f
  4. soxofaan
    added 3 commits that reference this issue on Aug 26, 2019

    Issue Open-EO#67: add `filter_temporal` and deprecate the old version…

    fd4d1f8

    Issue Open-EO#67: make `filter_bbox` the main method and deprecated `…

    24c6896

    Issue Open-EO#67 improve date (object) handling in `filter_temporal`

    06f07c5

  5. soxofaan commented on Sep 4, 2019

    @soxofaan
    soxofaan
    on Sep 4, 2019
    MemberAuthor

    issue resolved by #69

  6. soxofaan
    closed this as completedon Sep 4, 2019
  7. soxofaan
    added a commit that references this issue on Sep 6, 2019

    eliminate deprecated `bbox_filter` method (Issue Open-EO/openeo-pytho…

    2b6e1f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions