'local variable referenced before assignment' false positive #315

Activity

1. myint commented on Nov 28, 2017

   

   myint

   on Nov 28, 2017

   Last edited by myint

   Member

   More actions

   I don't have time to look into the details right now, but this seems somewhat reminiscent of previous conditional-related issues we've seen this in the past (like #252).

   (Though, in this particular example, there would an error in the code even if weren't for the errors.blah() false positive. Pyflakes would rightfully complain about the redefinition of errors.)
2. bitglue commented on Nov 28, 2017

   

   bitglue

   on Nov 28, 2017

   Member

   More actions

   But it is an error. Try this variation, which is a program we should expect to print hello world!:

   from pprint import pprint
   
   
   def test_f823():
       try:
           pprint('hello world!')  # this line should not produce a pyflakes error
       except Exception as error:
           pprint = [error]
           return pprint
   
   
   if __name__ == '__main__':
       print(test_f823())

   $ python3 test.py
   [UnboundLocalError("local variable 'pprint' referenced before assignment",)]
   $ python2 test.py
   [UnboundLocalError("local variable 'pprint' referenced before assignment",)]

   👍React with 👍1Reacted by Steven Myint
3. sigmavirus24 commented on Nov 28, 2017

   

   sigmavirus24

   on Nov 28, 2017

   Member

   More actions

   Right. This isn't a matter of pyflakes being nitpicky, this is totally a language issue.
4. bitglue commented on Nov 28, 2017

   

   bitglue

   on Nov 28, 2017

   Member

   More actions

   I'm closing this as it appears this is a true positive. Please reopen if there's something I'm overlooking.
5. bitglue

   closed this as completedon Nov 28, 2017