Use pre-commit hook with flake8 for contributors #456

Activity

1. bitglue commented on Aug 8, 2019

   

   bitglue

   on Aug 8, 2019

   Member

   More actions

   I personally don't like to conflate my git workflow with my testing cycle, so I run it manually or in tox.

   Travis catches any issues that make it into a PR.

   But if you would like to submit a configuration that makes it easier for people who do want to use pre-commit hooks to do so, without encumbering those who do not, that would be fine.
2. daneah commented on Jul 14, 2020

   

   daneah

   on Jul 14, 2020

   Last edited by daneah

   More actions

   @toti1212 is the suggestion here to create, specifically, a hook definition for use with pre-commit? I think this would meet the criteria @bitglue suggests—users could use pyflakes as a pre-commit (the tool) hook, but would not be required to in any sense.

   I'd be happy to submit such a pull request if that's amenable!