Skip to content
This repository was archived by the owner on May 25, 2022. It is now read-only.
This repository was archived by the owner on May 25, 2022. It is now read-only.

Weak Password Creation #447

Description

@KhyalKara

Description

The script python-password-generator.py uses random.sample to pick unique characters, without allowing repetition of characters.

In short the number of possible passwords is greatly reduced
Code in Question

Proposed Fix:

# Instead Use:
random.choices(total, k=length)

Type of issue

  • Bug

Checklist:

  • I have read the project guidelines.

  • I have checked all the existing projects, before submitting a new project issue.

  • I have checked previous issues to avoid duplicates.

  • This issue will be meaningful for the project.

  • I have added screenshots of the bug

  • I have added steps to reproduce the bug

  • I have proposed a possible solution for the bug

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions