Skip to content

Add hasObservers to Subject #1772

Closed
Closed
Add hasObservers to Subject#1772
Labels
Enhancement
Milestone
1.0

Description

@yogurtearl
yogurtearl
opened on Oct 16, 2014

Other implementations of Rx have a hasObservers method on Subject. It would be nice to have this in RxJava.

RxJS:
https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/subjects/subject.md#rxsubjectprototypehasobservers

Rx.NET
https://rx.codeplex.com/SourceControl/latest#Rx.NET/Source/System.Reactive.Linq/Reactive/Subjects/Subject.cs

Activity

  1. benjchristensen commented on Oct 17, 2014

    @benjchristensen
    benjchristensen
    on Oct 17, 2014
    Member

    I'm open to that. Want to submit a pull request?

  2. benjchristensen
    added this to the milestone on Oct 17, 2014
  3. benjchristensen
    added
    Enhancement
    on Oct 17, 2014

  4. simonbasle commented on Oct 27, 2014

    @simonbasle
    simonbasle
    on Oct 27, 2014
    Contributor

    went ahead and implemented the method (see pull request)

  5. benjchristensen
    added a commit that references this issue on Oct 28, 2014

    Merge pull request #1802 from simonbasle/hasObservers

    e7fa614
  6. benjchristensen
    modified the milestones: 1.0, on Oct 28, 2014

  7. benjchristensen commented on Oct 28, 2014

    @benjchristensen
    benjchristensen
    on Oct 28, 2014
    Member

    Merged.

  8. benjchristensen
    closed this as completedon Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions