Operation mergeDelayError(Observable<Observable<T>>) does not delay onError of parent observable

Shouldn't all onError calls including a possible onError call of the parent observable being delayed till all child observables have successfully finished emitting items or called onError themselves?

To get my desired behaviour I changed the code so now the onError method adds the error to the error queue and calls the onCompleted method which already does the propagation of received errors.

If this is still an issue can you provide a unit test?

I wrote a unit test. An Observable of asynchronous child Observables is calling onError after emitting the child Observables.

I created 2 branches:

https://github.com/EmteZogaf/RxJava/tree/mergeDelayErrorNotDelayingParentOnError having the unit test added and is failing.
https://github.com/EmteZogaf/RxJava/tree/mergeDelayErrorFix having the unit test and my proposed fix added and is succeeding.

Under what circumstances can the parent emit an error? The use cases you provide seem contrived, as mergeDelayError is a static method and therefore there is not a parent Observable to emit an error.

Observable.mergeDelayError(o1, o2, o3).subscribe()

In that code there are 3 Observable instances being merged, but no parent to emit an error.

Reviewing this again ... the signature where this could be an issue is:

public final static <T> Observable<T> mergeDelayError(Observable<? extends Observable<? extends T>> source)

Marking to be included in 1.0 work.

I'm sorry for this late reply. I haven't looked into this issue for a while as our project using RxJava is running without any problems. But I will try to update to the new version next month and use base RxJava only without any customizations we made to it back then. If this is still an issue I'll report here.

Marking as 1.x as this doesn't require a signature change so can be fixed without holding up 1.0

Merge branch 'mergeDelayErrorFix' of github.com:EmteZogaf/RxJava into…

Fix mergeDelayError Handling of Error in Parent Observable

Merge branch 'mergeDelayErrorFix' of github.com:EmteZogaf/RxJava into…

Fix mergeDelayError Handling of Error in Parent Observable

Navigation Menu

Repository navigation

Operation mergeDelayError(Observable<Observable<T>>) does not delay onError of parent observable #313

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Operation mergeDelayError(Observable<Observable<T>>) does not delay onError of parent observable #313

Description

Activity

benjchristensen commented on Dec 6, 2013

EmteZogaf commented on Feb 19, 2014

benjchristensen commented on May 20, 2014

benjchristensen commented on Jul 24, 2014

benjchristensen commented on Jul 24, 2014

EmteZogaf commented on Jul 24, 2014

benjchristensen commented on Sep 23, 2014

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions