Repository navigation
4.x: Separate TestHelper.race uses so they can run @Isolated #8075
Description
There are no failures but the race tests are there to provoke failures. Them not failing when run parallel might just indicate the failure condition wasn't triggered due to interleaving.
Separating them out and running them JUnit 6 @Isolated can restore faith.
Also double check for any manual racing tests that haven't been converted to TestHelper.race before.
PR Welcome.
Activity
oaksprout commentedon Jul 28, 2026
Would you want this one done? — Make RxJava's concurrency race-condition tests run isolated (JUnit
@Isolated) instead of in parallel with everything else, so a real race-condition regression can't be masked by interleaving with unrelated tests, and check for any manual racing tests that still need converting to the sharedTestHelper.racehelper. If yes, we'll do it and open a PR; if not, say so (or just ignore this) and we won't touch it.How it works: an AI agent does the work against your write-up; it's independently checked in a clean container (your test suite, network off) before anything reaches you; a human reviews it, submits it, and answers the review. You keep full control — nothing lands unless you merge it.
Recent examples of the same flow on other projects: stretchr/testify#1932, pypa/pip-audit#1089, openstreetmap/iD#12631.
We're testing whether work offered this way is useful to maintainers — a blunt "no" is as helpful as a yes.
akarnokd commentedon Jul 28, 2026
Not urgently but yes. The filename pattern should be the original name plus the word
Isolatedinserted before theTest.javapart.Please do the movements and conversions in separate PRs. You can do as many PRs in each category as you want.
oaksprout commentedon Jul 29, 2026
Thanks — first movements batch is up: #8253. Six classes from the Flowable flatMap/mergeWith family, named per your pattern, movements only. Kept it small so you can veto the shape before I produce the rest (179 files with
TestHelper.raceremain). Checked in a clean container before it went up — full record in the PR.Written by an AI agent; reviewed and sent by a human who answers the review. Say the batch size or grouping you'd prefer and the next ones will follow it.
Move TestHelper.race tests into @isolated classes: Flowable flatMap/m…
oaksprout commentedon Aug 3, 2026
Thanks for the honest answer above, genuinely useful to hear plainly. Batch 2 is up: #8257. Same shape as before, Observable family this time.
Move TestHelper.race tests into @isolated classes: batch 2 (#8075) (#…
Isolate Maybe takeUntil race tests (#8319)
test: isolate Maybe zip race tests (Related #8075) (#8320)
4.x: Isolate Maybe timeout race tests (#8321)
4.x: Isolate Maybe amb and concat race tests
4.x: Isolate Maybe amb and concat race tests
4.x: Isolate Maybe amb and concat race tests (#8329)