NPM Lists rxjs version 7.8.2 which includes breaking changes #7534

Activity

1. benlesh commented on Feb 23, 2025

   

   benlesh

   on Feb 23, 2025

   Member

   More actions

   Do you have an example of the code that broke between those two version?
2. benlesh commented on Feb 23, 2025

   

   benlesh

   on Feb 23, 2025

   Member

   More actions

   Okay, I tried out both versions testing firstValueFrom in each, I couldn't replicate any breakage. The link you provided is just a link to the npm page. Not sure what I'm supposed to get from that. I did a diff between 7.8.1 and 7.8.2 and I can't see any changes to the firstValueFrom code.

   I'm going to close this as I don't have enough information to address whatever is being reported here, and I'll note the only reason I tried is there are two 👍 emojis at the bottom.

   Thank you for trying to report something. I just can't figure out what it is you're trying to report.
3. benlesh

   closed this as completedon Feb 23, 2025
4. ilyakonrad commented on Feb 24, 2025

   

   ilyakonrad

   on Feb 24, 2025

   Last edited by ilyakonrad

   More actions

   @benlesh I have an example.

   checkStripeStatus() {
     return new Observable((observer) => {
       if (!this.organization) return
       this.stripeService.checkStripeVerificationStatus(this.organization.id).subscribe(
         (stripeRes) => {
           this.store.dispatch(new SetStripeStatus(stripeRes))
           observer.next() // <-- this breaks the build
         },
         () => {
           this.store.dispatch(new SetStripeStatus(null))
           observer.next()
         }
       )
     })
   }
   

   

   👍React with 👍1Reacted by Oliver Forral