You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Async subject and ReplaySubject still accept next messages #7576
Both AsyncSubject and ReplaySubject overrides Subject next method,
but even _throwIfClosed checked in every error/next/complete messages, is not checked in these two overriden methods.
It just check whether stopped or not, but not checked whether closed or not
of course it is checked by calling super.next() method but
if I manually set closed flag to true, the Subject become closed but not isStopped then
the buffer in ReplaySubject and _value in the AsynSubject effected with this value
next(value){
if (!isStopped) {
_buffer.push(value);
...
}
this._trimBuffer();
super.next(value)
}
Expected behavior
if a Subject closed, none of the message receieved/transmitted
here the message receieved updates the buffer/last value shouldn't this too
Activity