Repository navigation
Description
Student: vishwa sujitsinh solanki
Task: R51-T026 · 6 of 10
Repository: https://github.com/S-AI-Projects/javascript-algorithms
Assigned working branch: student/e26b07f0767
Goal
Work on src/algorithms/math/pascal-triangle/pascalTriangle.js. Refactor one coherent calculation in pascalTriangle while preserving its behavior for the fixture. Name the particular state or operation made clearer in the PR. Fixture: Use the smallest valid input and one ordinary input for pascalTriangle from src/algorithms/math/pascal-triangle/pascalTriangle.js. Write the literal inputs and independently calculated expected outputs in the tests before editing the implementation. The check must name the source line establishing each precondition.
Steps
- Read src/algorithms/math/pascal-triangle/pascalTriangle.js, especially
pascalTrianglenear line 5. Record its public inputs, result, mutation behavior and any external dependencies before changing it. - First capture behavior in tests; identify the smallest contiguous responsibility that can be named clearly.
- Extract or simplify that responsibility without changing algorithm, return type, ordering, side effects or public arguments.
- Implement work/R51-T026/check.py as a focused runner that executes the new checks and propagates failures. Native check to incorporate: run the repository test script in non-watch mode after installing from its lockfile; for browser-only code use a browser test instead of plain Node. Record the actual command and nonzero test count.
- Create the checks specified below and run
python3 work/R51-T026/check.py. Save inputs, expected versus actual results and tool versions in work/R51-T026/; a check must exit non-zero when an assertion fails. - Commit the repository change on branch R51-T026; prepare a PR to the organisation fork explaining the result and linking the checks. Keep each task independently reviewable. Remove work/R51-T026/ from a later upstream branch.
Done when
☐ The checked behavior is tied to pascalTriangle in src/algorithms/math/pascal-triangle/pascalTriangle.js; every assertion has an explicit expected value.
☐ Use the smallest valid input and one ordinary input for pascalTriangle from src/algorithms/math/pascal-triangle/pascalTriangle.js. Write the literal inputs and independently calculated expected outputs in the tests before editing the implementation. The check must name the source line establishing each precondition.
☐ Existing supported behavior and the public interface are preserved unless a failing regression demonstrates and documents a defect.
☐ The before/after tests agree and the diff contains one explained readability improvement.
☐ The change is not a repository-wide formatting pass or an unmeasured optimization.
Additional task guidance
Additional curated task guidance
Item:
src/algorithms/math/pascal-triangle
Task type:
Focused refactoring
Code change (goes into the PR):
src/algorithms/math/pascal-triangle/pascalTriangle.js: one localized refactor plus regression tests that lock down the fixture and the public contract.
Automated check:
python3 work/R51-T026/check.py
Prerequisites:
Node matching project CI, the project lockfile dependencies, and Python 3.
Upstream PR rules:
Keep the contribution scoped to the named item and follow the linked contribution instructions and repository CI. Submit coursework to the organisation fork first; keep work/ evidence out of any later upstream PR. Upstream acceptance is not a grading requirement. Policy: https://github.com/trekhleb/javascript-algorithms/blob/85293e3e2b88f4d2ce330d956b139cf628aa1e82/CONTRIBUTING.md
Change:
Replaces the shared task template with an item-specific contribution brief.
PR destination:
Upstream candidate after review
Submission checklist
- Complete this task and its checks.
- Add the required evidence and link your pull request here.
- Select this S-AI-Projects fork as the PR base repository.
- Request instructor review.
Keep this PR focused on this task. Do not submit assignment PRs to the upstream repository.
Activity