Skip to content

vishwa sujitsinh solanki — R51-T030: Strengthen the tests of generateKeyMatrix (hillCipher.js) [src/algorithms/cryptography/hill-cipher] #30

Open

Description

@ankushbisht01

Student: vishwa sujitsinh solanki

Task: R51-T030 · 10 of 10
Repository: https://github.com/S-AI-Projects/javascript-algorithms
Assigned working branch: student/e26b07f0767

Goal

Work on src/algorithms/cryptography/hill-cipher/hillCipher.js. Prove that a regression test can detect a plausible one-line mistake in generateKeyMatrix. Use the fixture and invariant: Check dimensions and independently calculated cell values; avoid applying square-matrix rules to rectangular inputs. Fixture: Use a small rectangular matrix when supported, a 1×1 matrix, and a zero-containing matrix. For determinant([[1,2],[3,4]]) the result is -2; use that only for a determinant interface.

Steps

  1. Read src/algorithms/cryptography/hill-cipher/hillCipher.js, especially generateKeyMatrix near line 13. Record its public inputs, result, mutation behavior and any external dependencies before changing it.
  2. In a temporary copy, alter one boundary comparison, accumulation or return condition relevant to the algorithm.
  3. Find a valid input for which the original and mutant differ; independently establish the correct output and reduce the input.
  4. Implement work/R51-T030/check.py as a focused runner that executes the new checks and propagates failures. Native check to incorporate: run the repository test script in non-watch mode after installing from its lockfile; for browser-only code use a browser test instead of plain Node. Record the actual command and nonzero test count.
  5. Create the checks specified below and run python3 work/R51-T030/check.py. Save inputs, expected versus actual results and tool versions in work/R51-T030/; a check must exit non-zero when an assertion fails.
  6. Commit the repository change on branch R51-T030; prepare a PR to the organisation fork explaining the result and linking the checks. Keep each task independently reviewable. Remove work/R51-T030/ from a later upstream branch.

Done when

☐ The checked behavior is tied to generateKeyMatrix in src/algorithms/cryptography/hill-cipher/hillCipher.js; every assertion has an explicit expected value.
☐ Use a small rectangular matrix when supported, a 1×1 matrix, and a zero-containing matrix. For determinant([[1,2],[3,4]]) the result is -2; use that only for a determinant interface.
☐ Existing supported behavior and the public interface are preserved unless a failing regression demonstrates and documents a defect.
☐ The original passes and the mutant fails the same named assertion for a semantic reason.
☐ The final implementation contains no mutation or test-only branch.

Additional task guidance

Additional curated task guidance

Item:
src/algorithms/cryptography/hill-cipher

Task type:
Mutation-resistant tests

Code change (goes into the PR):
Add a focused regression in the normal tests for src/algorithms/cryptography/hill-cipher/hillCipher.js and document the protected condition. Keep the deliberate mutant out of the final source.

Automated check:
python3 work/R51-T030/check.py

Prerequisites:
Node matching project CI, the project lockfile dependencies, and Python 3.

Upstream PR rules:
Keep the contribution scoped to the named item and follow the linked contribution instructions and repository CI. Submit coursework to the organisation fork first; keep work/ evidence out of any later upstream PR. Upstream acceptance is not a grading requirement. Policy: https://github.com/trekhleb/javascript-algorithms/blob/85293e3e2b88f4d2ce330d956b139cf628aa1e82/CONTRIBUTING.md

Source (pinned):
https://github.com/trekhleb/javascript-algorithms/blob/85293e3e2b88f4d2ce330d956b139cf628aa1e82/src/algorithms/cryptography/hill-cipher/hillCipher.js#L13

Change:
Replaces the shared task template with an item-specific contribution brief.

PR destination:
Upstream candidate after review

Submission checklist

  • Complete this task and its checks.
  • Add the required evidence and link your pull request here.
  • Select this S-AI-Projects fork as the PR base repository.
  • Request instructor review.

Keep this PR focused on this task. Do not submit assignment PRs to the upstream repository.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions