Skip to content

Anjali Dewangan — R51-T041: Lock down the contract of reverseBits (fastFourierTransform.js) [src/algorithms/math/fourier-transform] #41

Open

Description

@ankushbisht01

Student: Anjali Dewangan

Task: R51-T041 · 1 of 10
Repository: https://github.com/S-AI-Projects/javascript-algorithms
Assigned working branch: student/e26b07f0661

Goal

Work on src/algorithms/math/fourier-transform/fastFourierTransform.js. Create focused regression tests for reverseBits using the stated fixture. Test returned values and any observable mutation separately. Fixture: Use an empty supported value, a singleton and a three-element sequence [A,B,C], whose reverse is [C,B,A]. For strings, distinguish code points from bytes as documented.

Steps

  1. Read src/algorithms/math/fourier-transform/fastFourierTransform.js, especially reverseBits near line 11. Record its public inputs, result, mutation behavior and any external dependencies before changing it.
  2. Write independent expected results for the fixture before running the source. Run the baseline and explain any mismatch without assuming the implementation is correct.
  3. Add a regression per distinct behavior; assert contents rather than just successful execution.
  4. Implement work/R51-T041/check.py as a focused runner that executes the new checks and propagates failures. Native check to incorporate: run the repository test script in non-watch mode after installing from its lockfile; for browser-only code use a browser test instead of plain Node. Record the actual command and nonzero test count.
  5. Create the checks specified below and run python3 work/R51-T041/check.py. Save inputs, expected versus actual results and tool versions in work/R51-T041/; a check must exit non-zero when an assertion fails.
  6. Commit the repository change on branch R51-T041; prepare a PR to the organisation fork explaining the result and linking the checks. Keep each task independently reviewable. Remove work/R51-T041/ from a later upstream branch.

Done when

☐ The checked behavior is tied to reverseBits in src/algorithms/math/fourier-transform/fastFourierTransform.js; every assertion has an explicit expected value.
☐ Use an empty supported value, a singleton and a three-element sequence [A,B,C], whose reverse is [C,B,A]. For strings, distinguish code points from bytes as documented.
☐ Existing supported behavior and the public interface are preserved unless a failing regression demonstrates and documents a defect.
☐ The tests cover ordinary input, a smallest supported input and a repeated-value or equivalent domain boundary; each reports expected and actual results.

Additional task guidance

Additional curated task guidance

Item:
src/algorithms/math/fourier-transform

Task type:
Contract regression tests

Code change (goes into the PR):
Add focused tests in the repository’s existing test layout for src/algorithms/math/fourier-transform/fastFourierTransform.js; add a concise input/output contract beside reverseBits.

Automated check:
python3 work/R51-T041/check.py

Prerequisites:
Node matching project CI, the project lockfile dependencies, and Python 3.

Upstream PR rules:
Keep the contribution scoped to the named item and follow the linked contribution instructions and repository CI. Submit coursework to the organisation fork first; keep work/ evidence out of any later upstream PR. Upstream acceptance is not a grading requirement. Policy: https://github.com/trekhleb/javascript-algorithms/blob/85293e3e2b88f4d2ce330d956b139cf628aa1e82/CONTRIBUTING.md

Source (pinned):
https://github.com/trekhleb/javascript-algorithms/blob/85293e3e2b88f4d2ce330d956b139cf628aa1e82/src/algorithms/math/fourier-transform/fastFourierTransform.js#L11

Change:
Replaces the shared task template with an item-specific contribution brief.

PR destination:
Upstream candidate after review

Submission checklist

  • Complete this task and its checks.
  • Add the required evidence and link your pull request here.
  • Select this S-AI-Projects fork as the PR base repository.
  • Request instructor review.

Keep this PR focused on this task. Do not submit assignment PRs to the upstream repository.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions