Repository navigation
Description
Student: Anjali Dewangan
Task: R51-T044 · 4 of 10
Repository: https://github.com/S-AI-Projects/javascript-algorithms
Assigned working branch: student/e26b07f0661
Goal
Work on src/algorithms/sets/maximum-subarray/bfMaximumSubarray.js. Add a property test around bfMaximumSubarray: Preserve the documented output type, shape, ordering and input-mutation behavior; compare fresh equivalent inputs under controlled external state. Fixture: Use the smallest valid input and one ordinary input for bfMaximumSubarray from src/algorithms/sets/maximum-subarray/bfMaximumSubarray.js. Write the literal inputs and independently calculated expected outputs in the tests before editing the implementation. The check must name the source line establishing each precondition.
Steps
- Read src/algorithms/sets/maximum-subarray/bfMaximumSubarray.js, especially
bfMaximumSubarraynear line 8. Record its public inputs, result, mutation behavior and any external dependencies before changing it. - Use the fixture to establish the invariant on understandable examples. Use the smallest valid input and one ordinary input for
bfMaximumSubarrayfrom src/algorithms/sets/maximum-subarray/bfMaximumSubarray.js. Write the literal inputs and independently calculated expected outputs in the tests before editing the implementation. The check must name the source line establishing each precondition. - Generate at least 100 bounded valid cases with a fixed seed; restrict the generator to the actual input domain and retain a readable small case.
- Implement work/R51-T044/check.py as a focused runner that executes the new checks and propagates failures. Native check to incorporate: run the repository test script in non-watch mode after installing from its lockfile; for browser-only code use a browser test instead of plain Node. Record the actual command and nonzero test count.
- Create the checks specified below and run
python3 work/R51-T044/check.py. Save inputs, expected versus actual results and tool versions in work/R51-T044/; a check must exit non-zero when an assertion fails. - Commit the repository change on branch R51-T044; prepare a PR to the organisation fork explaining the result and linking the checks. Keep each task independently reviewable. Remove work/R51-T044/ from a later upstream branch.
Done when
☐ The checked behavior is tied to bfMaximumSubarray in src/algorithms/sets/maximum-subarray/bfMaximumSubarray.js; every assertion has an explicit expected value.
☐ Use the smallest valid input and one ordinary input for bfMaximumSubarray from src/algorithms/sets/maximum-subarray/bfMaximumSubarray.js. Write the literal inputs and independently calculated expected outputs in the tests before editing the implementation. The check must name the source line establishing each precondition.
☐ Existing supported behavior and the public interface are preserved unless a failing regression demonstrates and documents a defect.
☐ The generator never relies on undefined input behavior; the invariant is justified in the PR.
☐ The checks fail when the relevant invariant is deliberately broken in a temporary copy.
Additional task guidance
Additional curated task guidance
Item:
src/algorithms/sets/maximum-subarray
Task type:
Invariant/property checks
Code change (goes into the PR):
Add invariant-based tests for src/algorithms/sets/maximum-subarray/bfMaximumSubarray.js, with a deterministic seed and the smallest failing example; document the invariant next to the implementation.
Automated check:
python3 work/R51-T044/check.py
Prerequisites:
Node matching project CI, the project lockfile dependencies, and Python 3.
Upstream PR rules:
Keep the contribution scoped to the named item and follow the linked contribution instructions and repository CI. Submit coursework to the organisation fork first; keep work/ evidence out of any later upstream PR. Upstream acceptance is not a grading requirement. Policy: https://github.com/trekhleb/javascript-algorithms/blob/85293e3e2b88f4d2ce330d956b139cf628aa1e82/CONTRIBUTING.md
Change:
Replaces the shared task template with an item-specific contribution brief.
PR destination:
Upstream candidate after review
Submission checklist
- Complete this task and its checks.
- Add the required evidence and link your pull request here.
- Select this S-AI-Projects fork as the PR base repository.
- Request instructor review.
Keep this PR focused on this task. Do not submit assignment PRs to the upstream repository.
Activity