errors are cached and not reset if the component using useQuery is remounted

Here's an example: https://codesandbox.io/s/elegant-minsky-wwfko?file=/src/index.js

Close the error report window then click "retry". That will remount the Posts component but it will error immediately.

If you uncomment the queryCache.clear() it works.

I would expect that errors are not cached, or that they're cleared when the component is remounted.

My guess is that since the component never officially mounts, there's some edge case here that isn't accounted for, or that this is an intractable problem and I should just always clear the cache on an error (which may very well be a good idea anyway).

I’m looking into this

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Thank you for the quick fix.

Hello, I'm getting the same issue in v.2.26.4, so I guess there was a regression? Have solved it by clearing the cache as above, but just FYI. Thanks.

@tannerlinsley

@tannerlinsley I am also getting the same issue in v.2.26.3. For us the cache clearing is not an optimal solution. Perhaps this issue should be reopened?

Feel free to create a new issue / discussion with a codesandbox that shows the issue, preferably on v3.

For others facing this issue in v2.26.x, it looks like like the bug was also observed in #1412 (comment) and is being addressed in #1781

We just ran into the same issue with v3.27.0. If I get a chance to make a code sandbox I will.

This will get us by for now:

  const { reset } = useQueryErrorResetBoundary();
  const queryClient = useQueryClient();

  const resetErrors = () => {
    queryClient.clear();
    reset();
  }

  return (
    <ErrorBoundary onReset={resetErrors} fallbackRender={Fallback}>
      { children }
    </ErrorBoundary>
  );

Can you try updating to the latest version please? I remember we had a bug somewhere that was since fixed. Otherwise please open a new issue with a codesandbox reproduction

Navigation Menu

Repository navigation

errors are cached and not reset if the component using useQuery is remounted #468

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

errors are cached and not reset if the component using useQuery is remounted #468

Description

Activity

tannerlinsley commented on May 9, 2020

tannerlinsley commented on May 11, 2020

aaronjensen commented on May 11, 2020

jacklj commented on Dec 15, 2020

danowens1 commented on Jan 25, 2021

TkDodo commented on Jan 25, 2021

jakepeyser commented on Feb 11, 2021

tncbbthositg commented on Nov 11, 2021

TkDodo commented on Nov 11, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions