Repository navigation
Calling server function within another server function inside loader alters parameters unexpectedly #1866
Description
Describe the bug
When calling a server function inside another server function, the parameters get altered unexpectedly, causing the outer function to receive modified parameters. This issue prevents the function from being reusable as intended.
Your Example Website or App
N/A
Steps to Reproduce the Bug or Issue
- Define two server functions using
createServerFn:
export const serverFn = createServerFn('POST', async (params, ctx) => {
console.log(params)
await server2Fn(params)
return null
})
export const server2Fn = createServerFn('POST', async (params, ctx) => {
console.log(params)
return null
})-
Call the
serverFnfunction with the following parameters:// inside a loader await serverFn({ slug: { eq: 'test' } });
-
Observe the console logs for
paramswithinserverFn:Expected output:
{ "slug": { "eq": "test"} }Actual output:
{ "method": "POST", "payload": { "slug": { "eq": "test" } }, "requestInit": undefined }
Expected behavior
The createServerFn wrapper seems to be adding extra data to the parameters, such as method, payload, and requestInit. This behavior interferes with the intended parameter structure, making it difficult to reuse the server function properly.
Screenshots or Videos
No response
Platform
- OS: macOS
- Browser: Chrome
- Version: "@tanstack/react-router": "^1.43.3", "@tanstack/start": "^1.43.3"
Additional context
No response
Activity
[-]Calling server function within another server function alters parameters unexpectedly[/-][+]Calling server function within another server function inside loader alters parameters unexpectedly[/+]jadedevin13 commentedon Jul 1, 2024
I found that simply replacing the following lines
router/packages/start/src/client/createServerFn.ts
Lines 85 to 92 in bf52d5a
with
Solves my issue and doesn't cause issues with other server functions even when called in the react component. So I'm not sure why it's being called with those extra args.