Repository navigation
Chat shows raw 'Tool removed: ask_user_question' cell (remainder of #140; DSH core cell) #140
Description
Environment: ThinkFlowLab/FlyBot main 1ac7104 (core, plugins/social, plugins/tree) on @deepseek-ai/dsh@0.2.0-rc.2, two fresh installs on one Linux box (A on :3080, B on :3081), Bot Social server https://47-80-69-220.sslip.io. Found in the scheduled two-instance UI self-test on 2026-10-16 (~19:35 UTC+8).
What happened
- Auto-send is on by default for a new friend. B's Friends' Bots → SelfA1935 row has an "Auto-send" checkbox ("Don't ask each time.") that is checked right after accepting the invite. A's row for B is checked too. So outgoing messages to a new friend skip approval by default. (
client.jsrenderschecked: auto[home] !== falsewhile the plugin default isapproval.default: 'hold'.) - The checkbox shows a stale state. Clicking it showed the previous value, and only a reload showed the saved one. It took extra clicks and reloads to get it back to the original state.
- Owner sees the waiting notice. With friend Auto-send off, on A I sent "hi Chief from A" to "SelfB1935's Chief". A (the owner) got a bubble "Waiting for the owner's approval" and a docked panel above the composer "WAITING FOR APPROVAL / Helper → Chief / hi Chief from A" with Approve/Reject, plus a raw line "Tool removed: ask_user_question".
- Wrong sender. A message typed by the human SelfA1935 is labelled "Helper → Chief" on the card and arrives on B as "Helper · SelfA1935's Bot".
- Stale preview. After Approve (A shows "Approved", B receives it), A's sidebar row for SelfB1935's Chief still previews "Waiting for the owner's approval".
Repro
- A invites B to Helper; B accepts. Look at the Auto-send checkboxes on both sides.
- On A uncheck friend Auto-send, open SelfB1935's Chief, send a message.
- Look at the chat and sidebar, click Approve, look again.
Expected (owner design: approval in the chat itself)
- New friendships start in hold (Auto-send off); turning it on is an explicit choice, and the checkbox reflects the saved value at once.
- The owner sees Approve / Reject on the held message in the chat; only other members see "Waiting for the owner's approval".
- The held item names who wrote it (me, or my Bot when a Bot drafted it).
- No internal tool notices ("Tool removed: …") in the chat; previews update when the item is approved.
Related but not covered: #132 (Auto-send vs Auto-accept wording).
Activity
fix(social): name collisions, per-Bot grant leaks, Bot removal and ap…
Birfy commentedon Oct 16, 2026
Mostly fixed on main (
566f1e6) by #141 (and #142 for the Auto-send-on-accept path). One item remains; I changed the title to match.Fixed:
auto[home] === true, and the server auto-approve is only pushed if the owner opted in. Tests:#140: new friends default Auto-send off…,#140: respond Auto-send follows the accepted relationship….syncApprovalNoticespasseschats: false). Only other members of a shared room see it.approvalViewandlocalHoldView).Remaining:
Tool removed: ask_user_questionline still shows in the chat. fix(social): name collisions, per-Bot grant leaks, Bot removal and approval defaults (#136 #138 #139 #140) #141 noted it is a DSH core tool cell, and nothing in this repo suppresses it. It needs either hiding that cell through the pin/patch layer or an upstream change.Keeping this open for that.
[-]Approval: friend Auto-send is on by default, owner sees 'Waiting for the owner's approval', wrong sender label, stale state[/-][+]Chat shows raw 'Tool removed: ask_user_question' cell (remainder of #140; DSH core cell)[/+]fix(chat): hide the raw 'Tool removed: ask_user_question' line (Think…