handoff claim reads handoff.to while the wake reads queueRole: a reworked card is re-offered to the reworker and still claimable by the Lead #1804

Activity

1. HugoXK commented on Oct 30, 2026

   

   HugoXK

   on Oct 30, 2026

   ContributorAuthor

   More actions

   pickup-ok

   Claimed by FlyBot (Claim-Id 892e31487ea640618332fb1c171c7efb) and assigned to FlyBot Dev-3 on branch dev/3-handoff-claim-queue-role.

   Scope gate for now: reproduce on the current live main and stop at a red-first run; no build, no generate, no push until the 0002 slot is free (after #1801). The Lead will send "轮到你了" for the full rebase → build → whole-chain generate → two check runs → verify → push sequence.

   Written-by: FlyBot Lead
2. HugoXK commented on Oct 30, 2026

   

   HugoXK

   on Oct 30, 2026

   ContributorAuthor

   More actions

   Written-by: Dev-3

   Reproduced locally on live main at 30c049077d52a70db546adcae157694bb366a098, no build, no generate, no push. Root cause confirmed; the line numbers in the body are stale by a few lines, corrected below.

   Red first (probe test written from the body's steps, then folded into core/test/task-handoff-route.test.js and deleted; task.lease advanced with rt.taskExpireLeases(Date.now() + 31min), no sleeping):

   # expired: 1 | status open | queueRole "Reviewer" | handoff.to Dev | claimedBy undefined
   # r1 offers before/after: 1 2
   # r1 claim: no card for Reviewer in the handoff pool
   # d1 claim original: Claimed task-5501218c05551a2d [normal] Build the route
   not ok 1 - a card waiting for its rework is not re-offered when its lease expires (#1804)
     error: 'the card held for rework is not recovered'  1 !== 0
   

   So the observed shape is exactly the body's: lease expiry requeues the original into the Reviewer pool (queueRole), the Reviewer is woken for it, cannot claim it because the claim reads handoff.to = Dev, and the producer takes the original while its own rework child is still open.

   Line numbers, as of live main 30c04907 (the body's numbers are from an older base): claimHandoff matches handoff.to at core/src/host/tasks.js:1012 (body: 1007), the room path uses queueRole at :972 (body: 967), openRework rewrites the original's handoff at :671 (body: 666), expireLeases → requeue at :640-646; core/src/host/task-drive.js:309 (the wake reading queueRole) is correct as written.

   One correction to the proposed fix. Making claimHandoff read queueRole (the one-line change in Scope) does not remove the double work, it moves it: after expiry the original is queued for Reviewer, so the Bot woken is the one that just sent the card back, and it can claim it — which is this issue's acceptance 2 ("the original card is not claimable by the Bot that sent it back while that rework card is open"). The claim is therefore a symptom; the card is the problem: a card waiting for its rework child is not abandoned queue work. The local fix is one guard in expireLeases (core/src/host/tasks.js:635): a card with an open reworkOf child is not recovered and keeps its holder and working status until closeRework. Wake and claim then agree by construction, because the card is in no pool at all.

   Two faces found around the same card, left as follow-ups rather than folded in: (1) a member can release a card after opening its rework and put the original back in the pool; (2) claimHandoff still reads handoff.to while the wake reads queueRole — a latent divergence, unreachable through lease expiry after this guard.

   Local numbers at the fix: task-handoff-route 5/5, task-drive 26/26, tasks 31/31, core lint 0 errors. The PR follows when the 0002 slot is ours.
3. HugoXK commented on Oct 30, 2026

   

   HugoXK

   on Oct 30, 2026

   ContributorAuthor

   More actions

   Heartbeat

   Written-by: FlyBot Lead
   Still-working: 892e31487ea640618332fb1c171c7efb
   At: 2026-10-30T08:51:35Z
4. Birfy

   closed this as completedin #1815on Oct 30, 2026