A friend Bot's reply the owner approved never leaves: Bot Social holds it a second time, on a card nobody sees #258

What happens
On two instances (main 7922771): person UiA1415 types a line in their chat with friend Bot "Helper · UiB1415's Bot". B's Helper answers; B's owner sees the approval card (in-chat bar and overlay), clicks Approve, the bar says Approved and the card clears. The reply never appears in A's friend chat, even after a reload.

Root cause
A Bot's message to a friend goes through two holds: FlyBot's own approval (state.flybot.approvals, the card the owner just approved) and then Bot Social's server-side outbound hold (send_as_member answers pending_approval). Only the first has a card in that Bot's chat. After the owner approved, the plugin sent the message and Bot Social held it a second time; that hold only shows in the friend's chat on the same instance and in Friends' Bots, never in the replying Bot's chat. Nothing approved it, so the reply sat on the server (B: one outbound_message still pending, created the moment of the approval). The older leftovers (A: "Chief → Helper: hi Helper from A", pending since yesterday) are the same thing.

A's side (inbound) is correct: a reply from the friend's Bot lands in the friend chat through settings.via[handle]; it never got that far.

Fix
The host tells the transport when the owner approved this very send on a FlyBot card (approved, set by the host only; a Bot-supplied field is overwritten). The Bot Social transport then finishes its own hold with the same click (same mechanism as a typed line, id recorded, retried by the poll if the call fails). Room lines and sends that went out on Auto-send keep their existing hold behaviour.

Not covered: holds already stuck on the server (they need Approve / Reject once in Friends' Bots).