Skip to content

Approvals UI: overlay covers the chat bar, every card twice with different words and buttons #260

Closed

Description

@Birfy

Approvals UI (live verification, main 7922771):

  • The global overlay sits on top of the in-chat bar and hides its Reject buttons.
  • Every approval is drawn twice (bar and overlay), with different words ("Helper → Chief" vs "Sent by Helper"), different buttons (the overlay has no Always approve), and a long header ("Message to @chief.uia1415.home · messages to @uia1415.home's Bots need your approval").
  • The friend's Bot is named by its handle in the overlay, "Chief" in the bar.
  • A Bot's direct message to a friend showed in a Face-to-face room that merely contains that friend, not in the Bot's own chat.
  • "Always approve" is a third full button next to Approve / Reject.

Fix: one place per context. The chat's dock draws the card and claims its approval ids; the overlay draws no second card for them. An approval no open chat shows becomes a small pointer ("Helper → UiA1415's Chief · Waiting for approval · Review") that opens its chat, after a short delay so moving between chats does not flash it. Other policies' approvals keep the overlay card, with the same two lines and Approve / Reject. Cards name the friend's Bot as the chat list does. Always approve is a quiet link. Local holds no longer match a room by participant handle.

Activity

  1. Birfy commented on Oct 18, 2026

    @Birfy
    CollaboratorAuthor

    Fixed in #267 (merge 275e957).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions