Skip to content

A failed Bot Social hold has no Retry, and Approve all misses Bot Social holds #724

Closed

Description

@HugoXK

Written-by: Dev (via HugoXK)

What happened

Two defects in the Bot Social approval dock (plugins/social/client.js):

  1. localHoldView drops status/error, so a local hold whose send failed is drawn as "Waiting for approval" with Approve/Reject. Clicking either answers bot/stale and the async handler has no catch, so nothing visible happens and the card is stuck. There is no Retry, though the core supports decide(..., 'retry').
  2. "Approve all" keys on !entry.status, but social/status items carry status: 'pending': the button is missing when several Bot Social cards wait, and when a local hold makes it appear the bulk action approves only the local one.

Expected

A failed hold reads "Not sent" with its error and a Retry; Approve all appears for Bot Social holds and approves every pending card, leaving a failed one to Retry.

Change scope

plugins/social/client.js, plugins/social/test/social.test.js, docs/subsystems/social.md.

Fixed by PR #713.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions