Skip to content

smoke: mock admin @all + Writer compact-in-place both red on main #917

Closed

Description

@hsliuustc0106

Context

core/dev/check.sh --only smoke (mock LLM + DSH) fails 2 assertions on both main and #908 / issue/903-step0-default-harness. Confirmed not a #903/#908 regression (same fails at main tip 32f3e7c with same DSH build).

Observed on hk2 (infermatrix-hk2-hsliu) with DSH dsh-v0.2.0-rc.2, pnpm 11.7, built system.node. Shots: check-20261024-0230 (#903) and main worktree re-run.

Failures

  1. admin calls everyone — expect Chief to @all / answer everyone; got only 1 answer (我觉得可以。). Hypothesis: mock-llm admin detection uses a Members: … and you (admin). style regex that no longer matches the current group prompt → steward/Chief path never treats the caller as admin.
  2. Writer condensed in place — steward returns compact ×3 but part count still +3. Hypothesis: compact not applied in-place / still switches part; check parts.js / DSH compact path vs smoke expectation (CONTEXT_WINDOW=100000 CHECK_RATIO=0.45).

Out of scope

Acceptance

  • Fix mock admin detection (or prompt wording) so “admin calls everyone” passes under mock smoke.
  • Fix or correctly assert Writer compact-in-place so that case passes (investigate before changing product behavior).
  • core/dev/check.sh --only smoke green on the fix branch (mock; no API key).
  • Note any remaining DSH-side follow-ups if compact is upstream.

Related

Activity

  1. added a commit that references this issue on Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions