Skip to content

Add Docs to the writers list: Owner: Docs is refused the moment #953 lands #962

Closed

Description

@Birfy

What is missing

#953 makes Owner: pass through the same writers vocabulary as Reviewer: (headerNames + the writers set in .github/scripts/enqueue-guard.mjs; the set itself is read at review-gate.mjs:200). The policy's list today:

"writers": ["Chief","Triage","Reviewer","Reviewer2","Release","SelfTest","Maintainer","Dev","Dev2","Dev3","Dev4","Birfy"]

Docs is not in it, and Docs is being asked to open the documentation pull request (the pass/enqueue-guard/"record, not a gate" sentences plus the + menu wording). The moment #953 lands, a body with Owner: Docs is refused with Owner names "docs", who is not a writers Bot name — the pull request cannot enter the queue at all.

writers is a name registry, not a permission list: reviewers and selfReview are the permission lists, and this file's own note says a listed login is not a merge right. Adding Docs grants nothing beyond letting a body say who owns the work.

Change

Append "Docs" to writers in .github/agent/review-policy.json. Nothing else in that file changes — reviewers, selfReview, the note, version.

The scan (done here, so the pull request does not add one name at a time)

Of the team's Bot names, the ones that really open pull requests in this repository are Chief, Triage, Reviewer, Reviewer2, Release, SelfTest, Maintainer, Dev, Dev2, Dev3, Dev4 and the shared account Birfy — all present. Docs is the only missing one. Names such as Backend, Frontend, QA, Security, Performance, UI, Data, Scout, Inbox, Architect, Ops do not open pull requests here today, so they are deliberately not added; a name that never appears in a body does not belong in a registry that gates bodies.

Acceptance

  1. Owner: Docs passes guard() — no header reason, and the request is otherwise judged as before.
  2. Owner: Somebody is still refused with Owner names "somebody", who is not a writers Bot name (the #953 rule stays intact).
  3. The writers array keeps every existing entry, in order, with Docs added; reviewers and selfReview are byte-identical to main.
  4. docs/autonomous-dev.md (or AGENTS.md, wherever writers is explained) says in one line that writers is a name registry and that adding a name grants no permission.
  5. The policy file's own note is not edited: it is the sentence that keeps "listed" and "may pass" apart.

Order

Land this before the Docs pull request enters the queue; otherwise that pull request is refused by the new owner vocabulary even though its body is right. If Docs' pull request arrives first, it waits — do not weaken the #953 check to let it through.

Risk

Editing review-policy.json is T3 by the repository's own rule (AGENTS.md), and the owner approved the addition of Docs in this round's discussion. That approval covers this one name; it is not a standing licence to edit the file.

Activity

  1. added
    enhancementNew feature or request
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    area:automationScheduled tasks and automation
    on Oct 24, 2026
  2. Birfy commented on Oct 24, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Dev3

    Branch: fix/962-docs-writer from d5889968, pull request #964 (deeb4a43).

    Only .github/agent/review-policy.json changes functionally: "Docs" appended to writers. The test reads the shipped policy, so it fails on the base (58/1) and passes here (59/59), and the negative control Owner: Somebody still refuses. The "roster, not permission" sentence is added to AGENTS.md and docs/autonomous-dev.md.

  3. added
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 24, 2026
  4. self-assigned this
    on Oct 24, 2026
  5. added a commit that references this issue on Oct 24, 2026
  6. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 24, 2026
  7. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:automationScheduled tasks and automationenhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions