Repository navigation
Use buffer not string #36
Description
Lots of calls to getText on atom editor. Also our languageServiceHost specifically ScriptSnapshot is working on string. Make it use nodejs Buffer. Also do this when reading files etc.
Activity
basarat commentedon Jan 30, 2015
Blocked by : https://discuss.atom.io/t/getting-changes-in-textbuffer/14581
basarat commentedon Jan 30, 2015
Debounce linter further
Use on did change to just copy edit buffer.
And Debounce errors further
It is just might make autocomplete work as it is.
basarat commentedon Jan 31, 2015
Not needed.
Investigating.
basarat commentedon Feb 1, 2015
It seems like this is not the issue. The
program.languageServiceHost.updateScript(filePath, options.editor.getText());call only takes under 1ms on a 1000 line file (considered a largish file for most purposes).However the complete call to
requestHandlerin autocomplete plus is around100msWith
getCompletiontaking the majority of time.So moving this to the
wishlistcategory.basarat commentedon Feb 1, 2015
TODO: investigate if
getCompletionsmakes calls to the language service host and consider optimizations if that is what is taking too long.basarat commentedon Feb 26, 2015
Probably a good thing to do after #130
basarat commentedon Mar 10, 2015
We are not going to use a
buffer. Instead we will bring in the changes from TSServer