Repository navigation
Incorrect order of extend()ing compilerOptions #27
Description
In ts-node.ts around line 80,
config.compilerOptions = extend({
target: 'es5',
module: 'commonjs'
}, config.compilerOptions, {
sourceMap: true,
inlineSourceMap: false,
inlineSources: false,
declaration: false
})should be
config.compilerOptions = extend({
sourceMap: true,
inlineSourceMap: false,
inlineSources: false,
declaration: false
}, config.compilerOptions, {
target: 'es5',
module: 'commonjs'
})for { target: 'es5', module: 'commonjs' } to take precedence over user's options, which potentially may be intended for latest browsers environments.
Activity
blakeembrey commentedon Nov 6, 2015
@terasaka2k This is correct. The
sourceMapoptions need to override the user settings, there's specially handling for it. The user, however, could output ES6 or ES3 if they so wished. Same with the module environment.Edit: Accidentally hit enter.
darthtrevino commentedon Jan 26, 2016
Consider this use case: I'm using webpack to chain the typescript-loader and the babel-loader together to take advantage of babel's hook runtime for things like HMR. I want my tsconfig.json to target ES6 and let the babel-loader transpile from ES6 to ES5 for browsers.
However, in my server code, I want to go straight from TS to ES5. I would like to be able to do this:
And then what I would expect to happen in ts-node would be something like:
blakeembrey commentedon Jan 26, 2016
@darthtrevino I'm not sure who you're responding to, but that's how it works already and the reason I closed the issue. However, there's no
compilerOptionspass in tots-node, it's all fromtsconfig.json.blakeembrey commentedon Jan 26, 2016
It sounds like you're actually after a different feature? The ability to pass in compiler options that override
tsconfig.json?darthtrevino commentedon Jan 26, 2016
Correct
blakeembrey commentedon Jan 26, 2016
@darthtrevino #54
darthtrevino commentedon Jan 26, 2016
Sweet! Thanks @blakeembrey !