[js-api] DefaultValue needs updating #501

Activity

1. rossberg

   assigned

   takikawa

   on Dec 20, 2023
2. eqrion commented on Dec 20, 2023

   

   eqrion

   on Dec 20, 2023

   Contributor

   More actions

   Also, this algorithm is unrelated to JS and in fact duplicates the respective definition in the core spec. It might be preferable to expose that in the core spec's embedding interface and call into that.

   The JS-API default value function is slightly different than wasm's default value function. JSAPI-DefaultValue(externref) = undefined, while Wasm-DefaultValue(externref) = null. This is thanks to JS filling in missing parameters with undefined.
3. rossberg commented on Dec 21, 2023

   

   rossberg

   on Dec 21, 2023

   MemberAuthor

   More actions

   Fair enough, but it would still be preferable to handle only this special case here and then defer to the core spec for all regular cases.

   (Although personally I still think this special case is odd and instead it should only use undefined if explicitly given, not as default. There is precedence in JS for treating an absent parameter differently from explicit undefined, e.g., [].reduce(() => 0) throws TypeError, whereas [].reduce(() => 0, undefined) returns undefined.)
4. takikawa

   added a commit that references this issue on Feb 15, 2024

   [js-api][test] Refine DefaultValue for new reference types

   ...

   663c8d5
5. rossberg

   closed this as completedon Feb 16, 2024