Repository navigation
Couple of repos are failing to update #73
Description
Tests in the repo are currently out of date, e.g. tail-call has tests that use an old invalid get_local instruction even though upstream repo has already fixed them to local.get.
I tried rerunning the script myself, but at least couple of repos fail to update with merge conflicts:
!! failed to update repos: threads function-references
I'm not sure how these issues are usually resolved and at this point would ask someone more familiar with this repo to update the testsuite.
Activity
sunfishcode commentedon Jan 17, 2024
This message usually means there is a merge conflict between a proposal repo and the spec repo. Usually, the way to resolve it is to ask the maintainers of the proposal repo to update it to the latest spec repo, and fix the merge conflicts that arise.
RReverser commentedon Jan 17, 2024
Ok so I need to raise issues on proposal repos separately?
RReverser commentedon Jan 17, 2024
Done. Meanwhile, is it worth pushing the partial update here (without tests from those repos) or better to wait until we have no conflicts?
sunfishcode commentedon Jan 17, 2024
Thanks for filing those!
If you're asking about submitting manual changes, then no, this repo should only contain the results of running the script, so that it's always easy to keep it up to date without worrying about losing manual edits.
If the script ran to completion and said "done", then yes, it's ok to submit a PR with the changes it produced, even if there were proposal repos that were skipped due to conflicts.
RReverser commentedon Jan 17, 2024
Yes, I'm asking about the script output. I'll submit in a sec.
RReverser commentedon Jan 17, 2024
Done + submitted another PR for minor improvement to branch handling.
alexcrichton commentedon Oct 8, 2025
I believe this has since ben handled, and it's expected that the threads repo isn't updating, so closing.