Skip to content

fix(ci): Orthrus nightly image is labeled with github.sha instead of the checked-out nightly commit #1867

Open

Description

@Wikid82

What: On scheduled runs, github.sha is the head of the default branch (main), not the nightly commit that is checked out (nightly-build.yml:209), so values derived from it point at the wrong commit.

Where: .github/workflows/nightly-build.yml:542 (Orthrus build). The main Charon nightly build has the same pattern at :275-276 and is fixed by the semver build-metadata work (docs/plans/current_spec.md, F7).

Severity: low-medium

Suggested approach: Use the sha of the checked-out commit (git rev-parse HEAD after checkout) for the Orthrus version/VCS_REF as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

  • Status
    Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions