Skip to content

Add workqueue to retry failed informer events in WorkerPoolSyncer #728

Closed

Description

If an informer event in the WorkerPoolSyncer fails, the event is never retried. In the case of delete is causes permanently stale workers / actors. We should use a workqueue to retry in the case of failures.

Activity

  1. EItanya commented on Aug 4, 2026

    @EItanya
    Collaborator

    I have a slightly orthogonal, but related question. Why do we use controller-runtime managers for reconciling in the atecontroller and not for this?

  2. sfunkenhauser commented on Aug 4, 2026

    @sfunkenhauser
    CollaboratorAuthor

    Good question :)

    I'm not sure what the history is here, but ultimately we should move the WorkerPoolSyncer out of the apiserver (#729). This was meant to be a stop gap and should be the smallest change possible.

  3. EItanya commented on Aug 4, 2026

    @EItanya
    Collaborator

    That’s fine, but I think we should align on a single k8s reconcile pattern if possible

  4. sfunkenhauser commented on Aug 5, 2026

    @sfunkenhauser
    CollaboratorAuthor

    Fixed by #674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/api-machinerykind/bugSomething isn't working / bugfixesprio/P0Highest priority / required for next milestone

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions