Skip to content

v7.rc.0 serving 2x - 3x slower than stable versions on my projects #12432

Closed

Description

@elvisbegovic

Bug or Feature ?

- [x] bug report

Command ?

- [x ] serve --sourceMap=false

Versions ?

Angular CLI: 7.0.0-rc.1
Node: 10.9.0
OS: win32 x64
Angular: 7.0.0-rc.0
... common, compiler, compiler-cli, core, forms, http
... language-service, platform-browser, platform-browser-dynamic
... router
Package
@angular-devkit/* 0.9.0-rc.1
@angular-devkit/core 7.0.0-rc.1
@angular-devkit/schematics 7.0.0-rc.1
@angular/cdk 7.0.0-beta.2
@angular/cli 7.0.0-rc.1
@angular/material 7.0.0-beta.2
@ngtools/webpack 7.0.0-rc.1
@schematics/angular 7.0.0-rc.1
@schematics/update 0.9.0-rc.1
rxjs 6.3.3
typescript 3.1.1
webpack 4.19.1

Repro steps ?

Update from 6.2.3 to v7 rc0, it is first time to test cli v7 in my projet.
It is slower even when serving without sourcemaps.
So ng s or ng s --sourceMap=false same refresh cli server around 10seconds while it was around 2-3s before.

Log ?

https://gist.github.com/istiti/9da2393a26aeb0117932e56bb04edd9a

Useful details ?

I can say project is big relativly to what angular/cli can support without bazel (1000+ files) and can't share project unfortunately
I just come back to stable version of cli v.6.2.4 and angular (see working package.json) and I get this score when serving https://gist.github.com/istiti/fc8b629e0a7f7cab13b41b070cbfb94b

Thanks @clydin

Activity

  1. added this to the needsTriage milestone on Oct 2, 2018
  2. filipesilva commented on Oct 2, 2018

    @filipesilva
    Contributor

    Heya @istiti thanks for trying you the 7.0 RC!

    I'm going to try and repro this regression and see if I can get similar numbers to yours, then see what's causing it.

  3. modified the milestones: needsTriage, Backlog on Oct 2, 2018
  4. self-assigned this
    on Oct 2, 2018
  5. Enngage commented on Oct 2, 2018

    @Enngage

    I'm experiencing similar/same behavior. In my case the compiler gets stuck on my sass files for a really long time. Prior to this 7.rc.0 version it went through my sass in few seconds, now it takes up to 2-3 minutes. Eventually, it does work fine though.

  6. filipesilva commented on Oct 2, 2018

    @filipesilva
    Contributor

    @Enngage do you have a reproduction I can look at?

  7. 30 remaining items

  8. filipesilva commented on Oct 10, 2018

    @filipesilva
    Contributor

    @istiti glad to hear the rebuild times are back to what they should be! extractLicenses being on was a bug on our side though, it didn't have anything to do with your configuration. We'll be looking at the assets issue in the future as well.

  9. filipesilva commented on Oct 10, 2018

    @filipesilva
    Contributor

    @Enngage sorry I forgot that your problem was somewhat different. You can see the increased build times on initial builds, correct?

    Then you should be able to do ng build --prod --profile with the latest RC (@angular-devkit/build-angular@0.9.0-rc.2). This will create 2 json files at the root of the project. Can you send those over please?

  10. filipesilva commented on Oct 12, 2018

    @filipesilva
    Contributor

    The rc.3 should contain the fix I mentioned about licenses not being extracted by default. I think that was the last bit to restore rebuilds to parity.

  11. elvisbegovic commented on Oct 12, 2018

    @elvisbegovic
    ContributorAuthor

    I agree i mark it as closed. Apologize me i didnt follow @Enngage problem, reopen it if needed

  12. filipesilva commented on Oct 12, 2018

    @filipesilva
    Contributor

    @istiti @Enngage just wanted to say thank you again for taking the time to take the profiles and try to get to the bottom of this with us. It's really hard to find some performance regressions as sometimes they don't manifest in all projects.

    @Enngage if you get around to making that new profile, can you open a new issue and indicate what types of builds it happens on, and also add the details about the scss please?

  13. Hypenate commented on Nov 23, 2018

    @Hypenate

    Just hopping in on this.
    I was getting an error (call_and_retry_last allocation) when I would ng build --prod my project, ng serve and ng build worked fine.
    The ng build --prod would run forever until it threw this error.

    I updated to the latest node.js and turned sourceMap: true to sourceMap: false in both tsconfig.js and angular.json.

  14. kondi commented on Dec 17, 2018

    @kondi

    I think that was the last bit to restore rebuilds to parity.

    @filipesilva In my project the rebuild time with @ngtools/webpack 7.0.7 is 644.6 ms (avg of 5 stable), but with version 7.1.3 it is 1476.6 ms. I would say in this case this is not in parity (2.3x slowdown), do you agree? Shall I provide something to profile or is it known issue? (#13102 maybe?)

  15. filipesilva commented on Dec 17, 2018

    @filipesilva
    Contributor

    @kondi that's another (different) regression, we are looking at it in #13102.

  16. angular-automatic-lock-bot commented on Sep 9, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  17. locked and limited conversation to collaborators on Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions