GitHub Integration is not pushing changes in PRs #1417

Activity

1. thdxr

   assigned

   fwang

   on Aug 4, 2025
2. fwang commented on Aug 22, 2025

   

   fwang

   on Aug 22, 2025

   Contributor

   More actions

   hmm that's weird... does this happen everytime?
3. AKTheKnight commented on Nov 4, 2025

   

   AKTheKnight

   on Nov 4, 2025

   Contributor

   More actions

   Think I've hit this too, couldn't find this issue (Thanks bot for telling me): #3893

   As far as I can tell it's because the branchIsDirty() check is false because git status --porcelain returns nothing if we've committed the changes, even if they haven't been pushed

   

   👍React with 👍1Reacted by Rohit Gohri
4. code-yeongyu commented on Feb 7, 2026

   

   code-yeongyu

   on Feb 7, 2026

   Contributor

   More actions

   Root Cause Analysis

   The bug has been identified. There are two separate implementations of branchIsDirty():

   1. github/index.ts (Used by GitHub Action) — BUGGY ❌

   // Line 751-755
   async function branchIsDirty() {
     console.log("Checking if branch is dirty...")
     const ret = await $`git status --porcelain`
     return ret.stdout.toString().trim().length > 0
   }

   This only checks for uncommitted changes via git status --porcelain. If the AI agent already committed the changes (via git commit), git status --porcelain returns empty — so this function returns false, and the push is skipped.

   2. packages/opencode/src/cli/cmd/github.ts (Used by CLI opencode github) — FIXED ✅

   // Line 1112-1127
   async function branchIsDirty(originalHead: string) {
     console.log("Checking if branch is dirty...")
     const ret = await $`git status --porcelain`
     const status = ret.stdout.toString().trim()
     if (status.length > 0) {
       return { dirty: true, uncommittedChanges: true }
     }
     const head = await $`git rev-parse HEAD`
     return {
       dirty: head.stdout.toString().trim() !== originalHead,
       uncommittedChanges: false,
     }
   }

   This correctly captures originalHead before AI work, then compares HEAD after — detecting both uncommitted changes AND new commits.

   The Fix

   The github/index.ts implementation needs to be updated to match the CLI version:

   1. Capture originalHead = git rev-parse HEAD before calling chat()
   2. In branchIsDirty(), check both git status --porcelain AND HEAD !== originalHead
   3. Pass uncommittedChanges flag to push functions so they know whether to git add . && git commit first

   As @AKTheKnight correctly identified in #3893, the branchIsDirty() check is false because git status --porcelain returns nothing after committed changes.

   The fix already exists in the CLI version (packages/opencode/src/cli/cmd/github.ts), it just needs to be ported to the GitHub Action version (github/index.ts).
5. github-actions commented on Apr 9, 2026

   

   github-actionsBot

   on Apr 9, 2026 – with GitHub Actions

   Contributor

   More actions

   To stay organized issues are automatically closed after 90 days of no activity. If the issue is still relevant please open a new one.
6. github-actions

   closed this as completedon Apr 9, 2026