Activity

1. github-actions

   assigned

   nexxeln

   on May 19, 2026
2. LucaWolf commented on Jul 17, 2026

   

   LucaWolf

   on Jul 17, 2026

   Last edited by LucaWolf

   More actions

   OpenCode, I was about to subscribe but not trusting the process at this moment :-( I do not want "try and see if it worked" or to fiddle with support emails and what not. Please review and address the ticket. This is what Github's copilot says about the matter (regardless if AI slop or not)

   Root Cause

   Missing Payment Confirmation for Subscription Activation
   The Issue:

   When customer.subscription.created fires (line 108), the code immediately activates the subscription (sets lite: {} at line 150) without verifying that the initial invoice payment succeeded.

   The subscription can be created by Stripe even when:

   The payment is still pending (e.g., requires 3DS)
   The invoice hasn't been paid yet
   The subscription status is incomplete or incomplete_expired
   

   What Happens:

   customer.subscription.created fires → Subscription activated immediately ✓
   Payment requires 3DS verification → User is shown 3DS prompt
   Payment eventually succeeds at Stripe → invoice.payment_succeeded fires with billing_reason: "subscription_create"
   But the webhook only records the payment (inserts to PaymentTable, line 245-258), it does NOT activate the subscription because it's already activated
   

   The Gap:

   The invoice.payment_succeeded handler (lines 210-258) for subscription creation does NOT include:

   // This is MISSING - no update to actually activate/enable the subscription
   await tx.update(BillingTable).set({
     lite: {},  // Should set this when invoice payment succeeds
     // ... other fields
   }).where(eq(BillingTable.workspaceID, workspaceID))

   So if the subscription was already set to active but there's a failure state or the system crashes between events, OR if there's a condition where the subscription needs to transition from incomplete to active, there's no handler to actually mark it as successfully activated.
   Even Worse - Incomplete Subscriptions:

   Line 187-196 handle customer.subscription.updated only when status is incomplete_expired, which deactivates the subscription. But there's no handler for when the subscription transitions from incomplete → active after successful payment.
   Scenario That Breaks:

   User subscribes → customer.subscription.created fires → lite: {} is set (activates)
   3DS verification required
   User completes 3DS
   invoice.payment_succeeded fires → payment recorded but no subscription state update
   If there's any system state mismatch, the subscription appears inactive even though payment succeeded
   

   Fix Needed:

   Add a handler for when subscription completes payment:

   if (body.type === "customer.subscription.updated" && 
       body.data.object.status === "active" && 
       body.data.previous_attributes?.status !== "active") {
     // Subscription just became active after payment confirmation
     // Ensure lite subscription is properly activated
   }

   Or better: ensure invoice.payment_succeeded with billing_reason: "subscription_create" also updates subscription activation status in your database.

   👍React with 👍2Reacted by Marco Bulgarelli and marcomezzaro
3. github-actions commented on Sep 17, 2026

   

   github-actionsBot

   on Sep 17, 2026 – with GitHub Actions

   Contributor

   More actions

   To stay organized issues are automatically closed after 60 days of no activity. If the issue is still relevant please open a new one.
4. github-actions

   closed this as not plannedon Sep 17, 2026