Skip to content

fix(app): auto-accept toggle disabled when no session is open #48238

Closed as not planned

Description

@johnhenry030888

The Settings → General auto-accept permissions switch is greyed out whenever no session is open (home / new-session / draft views), because createPermissionScopeController resolves its directory only from session lineage and the settings dialog never forwards the route directory it already computes.

Suggested fix (tested locally against v1.18.29): add a fallbackDirectory to the controller (session lineage first, route directory otherwise) and thread directory() from DialogSettings through SettingsGeneralV2. With no session, the switch reflects and writes the directory-level flag, which new sessions already inherit on submit (submit.ts shouldAutoAccept → enableAutoAccept). The switch stays disabled only when no directory is known at all.

Local patch available on request (3 files, +25/−9).

Activity

  1. johnhenry030888 commented on Sep 9, 2026

    @johnhenry030888
    Author

    Duplicate of #48237 (double-filed while verifying the repo redirect).

  2. github-actions commented on Sep 9, 2026

    @github-actions
    Contributor

    This issue does not follow our contributing guidelines.

    What needs to be fixed:

    • No issue template was used. All issues must use one of the three templates: Bug Report, Feature Request, or Question. This issue was filed with a commit-style title and free-form body rather than the required template format.
    • Bug reports should include the required Description field from the Bug Report template, along with reproduction steps and system information.

    Please edit this issue to address the above within 2 hours, or it will be automatically closed.


    This issue may also be a duplicate of existing issues. Please check:

    If you believe this was flagged incorrectly, please let a maintainer know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

needs:complianceThis means the issue will auto-close after 2 hours.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions