tool/edit: stale-content error mentions "permission approval" though any concurrent write triggers it #48707

Activity

1. github-actions

   assigned

   kitlangton

   on Sep 12, 2026
2. rareboe commented on Sep 14, 2026

   

   rareboe

   on Sep 14, 2026

   More actions

   Taking this one.

   Confirmed both ends in the source:

   • packages/core/src/file-mutation.ts raises StaleContentError from writeIfUnchanged, purely on a byte comparison under the per-path lock:

     const current = yield* fs.readFile(input.target.canonical)
     if (!sameBytes(current, input.expected)) {
       return yield* new StaleContentError({ path: input.target.canonical })
     }

   • packages/core/src/tool/edit.ts is the only place that maps it, and it's the mapping that introduces the permission wording — the error itself carries just a path.

   So the message names a cause the error has no knowledge of. Any writer touching the file inside the read→write window produces it, permission flow or not.

   I'll switch it to the wording you suggested, File changed since it was read. Read it again before editing., which describes the actual condition and keeps the same remedy. packages/core/test/tool-edit.test.ts pins the current string, so that assertion gets updated in the same PR — which also keeps the change provably scoped to this one message.

   PR shortly.
3. opencodejr commented on Oct 28, 2026

   

   opencodejrBot

   on Oct 28, 2026

   More actions

   Thanks for the detailed report!

   I couldn't find the message File changed after permission approval. Read it again before editing. or FileMutation.StaleContentError in v2.0.2 or in the current dev branch. In those versions the edit tool is packages/core/src/tool/plugin/edit.ts, and file-mutation.ts no longer has that stale-content check (writes to the same path are serialized by a lock instead). The code you mention was in older source that has since been replaced, which may also be why #48904 was closed.

   Could you share:

   • The exact output of opencode --version from the install where you saw this error.
   • The actual tool output or log lines showing the message, if you saw it in a real session rather than in the source.

   If you can still get this message on a current v2 release (latest is v2.2.0), please include the output. You can reply here with the details, or edit the issue. If you edit it, please also leave a comment saying you've updated it, so we know you're done.

   Related items, ordered by how closely they relate:

   • fix(core): describe the real cause of the edit stale-content failure #48904: your PR that changed this message (closed unmerged because it targeted the old code)
   • fix(opencode): reject stale patch sources after approval #47956: rejecting stale patch sources after approval
4. opencodejr

   added

   triaging

   on Oct 28, 2026
5. opencodejr

   closed this as not plannedon Oct 31, 2026
6. opencodejr commented on Oct 31, 2026

   

   opencodejrBot

   on Oct 31, 2026

   More actions

   Closing this as not planned since we haven't heard back. We were waiting for the exact opencode --version and the actual tool output showing File changed after permission approval. Read it again before editing. That message and FileMutation.StaleContentError are in older source but not in v2.0.2 or the current dev branch, so there was nothing we could reproduce on the version you reported.

   If you still see this message on a current v2 release, please open a new issue with the version and the output, and link back to #48707. Thanks for taking the time to report it!